Bug #76307 [Fbk->Opn]: strftime format %Z crash php

Edit report at https://bugs.php.net/bug.php?id=76307&edit=1 ID: 76307 User updated by: drop_box at live dot de Reported by: drop_box at live dot de Summary: strftime format %Z crash php -Status: Feedback +Status: Open Type: Bug Package: Date/time related Operating System: Windows 10 1803 PHP Version: 7.2.5 Block user comment: N Private report: N New Comment: Well i use here the x86 ts version of php, on the other hand I try my best to compile my self a debug version, because i don't understand what the meaning of "debug symbols" is. Here the output of my 7.2.5 debug x86 ts version: php7ts_debug.dll!php_strftime(_zend_execute_data * execute_data, _zval_struct * return_value, int gmt) line 1707 C php7ts_debug.dll!zif_strftime(_zend_execute_data * execute_data, _zval_struct * return_value) line 1740 C php7ts_debug.dll!ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER(_zend_execute_data * execute_data) line 617 C php7ts_debug.dll!execute_ex(_zend_execute_data * ex) line 59723 C php7ts_debug.dll!zend_execute(_zend_op_array * op_array, _zval_struct * return_value) line 63760 C php7ts_debug.dll!zend_execute_scripts(int type, _zval_struct * retval, int file_count, ...) line 1496 C php7ts_debug.dll!php_execute_script(_zend_file_handle * primary_file) line 2590 C php.exe!do_cli(int argc, char * * argv) line 1011 C php.exe!main(int argc, char * * argv) line 1404 C Previous Comments: ------------------------------------------------------------------------ [2018-05-09 07:08:01] ab@php.net Ohh, I've also overseen setlocale(). Besides them likely to be failing, they're not thread safe. There could be a race condition, as while one thread calls setlocale(), another one calls strftime(). But since the same does repro on CLI, it is most likely not the case. A good idea is probably to move such code to ICU. Still, there was issues with strftime alone in the past, when the receiving buffer was initially too small. If the CRT upgrade didn't help, i can provide a test build with an increased initial buffer, lets see. @drop_box, which exact PHP builds do you use? Thanks. ------------------------------------------------------------------------ [2018-05-08 20:04:02] requinix@php.net True, they won't work on Windows (should be "english_United States"), but fixing it doesn't repro for me. Today MS pushed out KB4103721 which "addresses additional issues with updated time zone information". https://support.microsoft.com/en-us/help/4103721 It brings ucrtbase.dll from version 10.0.17134.12 (at least that's what the Windows SDK has) to 10.0.17134.48. I hate to ask you to install an update as fresh as this but that changelog entry sounds suspiciously relevant. ------------------------------------------------------------------------ [2018-05-08 19:15:46] cmb@php.net I'm somewhat startled regarding the setlocale() calls, since these are supposed to fail due to wrong locales, aren't they? ------------------------------------------------------------------------ [2018-05-08 18:10:48] ab@php.net That's actually same as before. The first one shows something about ext/libxml, but the second one doesn't. The common part is still in strftime, which is a function from the CRT. Unfortunately no much details, as the debug symbols are not used. You can fetch the corresponding debug symbols from https://windows.php.net/downloads/releases/ . Otherwise, i'm still scratching my head about how to reproduce it. The only laptop with this upgrade doesn't show the regression :/ Perhaps you could also check, whether you're using the latest vc15 redistributable and upgrade it if you don't? Thanks. ------------------------------------------------------------------------ [2018-05-07 13:18:06] drop_box at live dot de Now I startet directly from cli and checked all files, now looks better in my eyes: ntdll!RtlReportCriticalFailure+88 ntdll!RtlpReportHeapFailure+2f ntdll!RtlpLogHeapFailure+41 ntdll!RtlFreeHeap+48251 ucrtbase!_free_base+1b ucrtbase!__crt_unique_heap_ptr<char,__crt_internal_free_policy>::~__crt_unique_heap_ptr<char,__crt_internal_free_policy>+c ucrtbase!strftime+1a php7ts!php_strftime+1fc php7ts!zif_strftime+f php7ts!ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER+6b php7ts!execute_ex+78 php7ts!zend_execute+152 php7ts!zend_execute_scripts+96 php7ts!php_execute_script+1f6 0x14a00000 ucrtbase!_LocaleUpdate::_LocaleUpdate+115 php7ts!php_execute_script+c1 php!do_cli+ea php!do_cli+950 0x004e0000 ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=76307 -- Edit this bug report at https://bugs.php.net/bug.php?id=76307&edit=1