Bug #76443 [Ver]: php+php_interbase.dll crash on module_shutdown

Edit report at https://bugs.php.net/bug.php?id=76443&edit=1 ID: 76443 Updated by: kalle@php.net Reported by: phpdev at ehrhardt dot nl Summary: php+php_interbase.dll crash on module_shutdown Status: Verified Type: Bug Package: InterBase related Operating System: Windows PHP Version: 7.3.0alpha1 Block user comment: N Private report: N New Comment: @jan I sadly don't have a working dev environment with Firebird setup, so it would be a while before I would be able to test. @christoph Simply reverting my commit should do the trick. Do you have any other places in paticular where you could see this could be an issue? Previous Comments: ------------------------------------------------------------------------ [2018-06-11 00:14:47] phpdev at ehrhardt dot nl @kalle: I tested the same thing with one of the recent snapshots at https://windows.php.net/downloads/snaps/master/ with the same segfault as a result. @christoph: I am not really into the internals of Windows, but reversing Kalle's commit did indeed solve it. FWIW: I recompiled all my builds at https://www.apachelounge.com/viewtopic.php?p=36936#36936 without any problems. Did not run any tests though, due to lack of a operating Firebird server. Maybe Kalle can run the tests. ------------------------------------------------------------------------ [2018-06-10 23:38:38] cmb@php.net Thanks for testing (and for reporting this issue in the first place), Jan! I'm not quite sure how to resolve this; see <http://news.php.net/php.internals.win/1188>. ------------------------------------------------------------------------ [2018-06-10 23:22:20] kalle@php.net Ah yes I see, should be fine reverting it tho I never experienced any issue with it back when I implemented it which I guess is why it was not caught until now ------------------------------------------------------------------------ [2018-06-10 21:16:13] phpdev at ehrhardt dot nl The hammer on the nail! So this commit by @KalleZ should be reversed: https://github.com/php/php-src/commit/fd29202022ecd952c175a3d1f805678801092be4#diff-e9c0f3e6898bf699286fc2fa83998cb7 ------------------------------------------------------------------------ [2018-06-10 20:52:18] cmb@php.net According to GetModuleHandle docs[1]: | Therefore, do not pass a handle returned by GetModuleHandle to | the FreeLibrary function. So please try again after removing the FreeLibrary() call[2]. [1] <https://msdn.microsoft.com/de-de/library/windows/desktop/ms683199(v=vs.85).aspx> [2] <https://github.com/php/php-src/blob/php-7.3.0alpha1/ext/interbase/interbase.c#L837>. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=76443 -- Edit this bug report at https://bugs.php.net/bug.php?id=76443&edit=1