Bug #76446 [Ana->Csd]: zend_variables.c:73: zend_string_destroy: Assertion `!(zval_gc_flags((str)->gc.

Edit report at https://bugs.php.net/bug.php?id=76446&edit=1 ID: 76446 Updated by: laruence@php.net Reported by: spam2 at rhsoft dot net Summary: zend_variables.c:73: zend_string_destroy: Assertion `!(zval_gc_flags((str)->gc. -Status: Analyzed +Status: Closed Type: Bug Package: Reproducible crash PHP Version: master-Git-2018-06-11 (Git) Block user comment: N Private report: N New Comment: Automatic comment on behalf of laruence@gmail.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=609385bbf8fc82f334778bdfef5e16b7a3bd72c6 Log: Fixed bug #76446 (zend_variables.c:73: zend_string_destroy: Assertion `!(zval_gc_flags((str)->gc)). Previous Comments: ------------------------------------------------------------------------ [2018-06-13 07:09:15] laruence@php.net > However, in this case we are not able to prove that the ROPE_ADD will not generate an error > (e.g. array to string conversion warning). this is checked in may_throw , I think make ROPE_END having side-affect is a safe way for 7.3, we could seek more aggressive way for 7.4 I am going to commit the fix, thanks ------------------------------------------------------------------------ [2018-06-12 22:27:42] cmb@php.net > "just mark ROPE_END as having side-effects with a FIXME that > this may be improved" don't help anybody […] Please try “disable-ROPE_END-dce.patch”. ------------------------------------------------------------------------ [2018-06-12 22:27:06] cmb@php.net The following patch has been added/updated: Patch Name: disable-ROPE_END-dce Revision: 1528842426 URL: https://bugs.php.net/patch-display.php?bug=76446&patch=disable-ROPE_END-dce&revision=1528842426 ------------------------------------------------------------------------ [2018-06-12 21:47:39] spam2 at rhsoft dot net whatever optimization it was - it's not worth the trouble - frankly half of my codebase segfaults without the slightest chance to make any workarounds because it segfaults long before any code is executed and so even trigger_error(__FILE__ . ' ' . __LINE__) spread around source files don't help becaus eit never get executed "just mark ROPE_END as having side-effects with a FIXME that this may be improved" don't help anybody - i can't even build a binary because as long as the test-suite crashes the rpmbuild is stopped for good reasons and all my gdb-stuff was with the intermediate binary after the build crashed ------------------------------------------------------------------------ [2018-06-12 21:39:56] cmb@php.net > I think for now we should just mark ROPE_END as having > side-effects with a FIXME that this may be improved. I'd very much appreciate to have *some* fix for this nasty *abort* in 7.3.0alpha2, if possible; otherwise we might hamper further testing of other stuff. Your suggestion seems to be rather innocuous – to my knowledge, it would just mean to move a single line, and to loose a somwehat rare and minor optimization. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=76446 -- Edit this bug report at https://bugs.php.net/bug.php?id=76446&edit=1