#19749 [Opn]: shouldn't mmap() files larger than memory_limit in _php_stream_passthru

From: Date: Sat, 05 Oct 2002 15:17:31 +0000
Subject: #19749 [Opn]: shouldn't mmap() files larger than memory_limit in _php_stream_passthru
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-21571@lists.php.net to get a copy of this message 
 ID:               19749
 Updated by:       rasmus@php.net
 Reported By:      rasmus@php.net
 Status:           Open
 Bug Type:         Performance problem
 Operating System: All
 PHP Version:      4CVS-2002-10-04
 Assigned To:      wez
 New Comment:

Yup, we should do it in chunks of some fraction of memory-limit, I
guess.  quarters, fiths, tenths?  It should be a decently big chunk
size so there will be a good chance that many files fit into a single
chunk for optimal speed.


Previous Comments:
------------------------------------------------------------------------

[2002-10-05 06:34:33] wez@php.net

How do we tell when a file is too big?
We can check if the file size exceeds the memory limit, but
surely we should be checking for some size smaller than
that so that we don't exceed the limit (by too much).


------------------------------------------------------------------------

[2002-10-04 03:21:22] rasmus@php.net

We should check the memory limit before mmap()'ing a huge file in
_php_stream_passthru()

------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=19749&edit=1

Thread (9 messages)

« previous php.bugs (#21571) next »