Bug #76029 [NoF]: Serious regression in foreach() looping
| From: | nikic@php.net | Date: | Sun, 24 Jun 2018 09:25:56 +0000 |
| Subject: | Bug #76029 [NoF]: Serious regression in foreach() looping | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-215947@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=76029&edit=1
ID: 76029
Updated by: nikic@php.net
Reported by: mark dot scherer at spryker dot com
Summary: Serious regression in foreach() looping
Status: No Feedback
Type: Bug
Package: *General Issues
Operating System: Linux
PHP Version: 7.2.2
Block user comment: N
Private report: N
New Comment:
There has been one smart-branch related fix in https://github.com/php/php-src/commit/6738d19fb80b8696f163cae4b9c114c247606daa,
which probably resolved this issue as well. Might be worth trying to reenable optimization_level and
see if the problem went away.
Previous Comments:
------------------------------------------------------------------------
[2018-06-24 04:25:40] php-bugs at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
------------------------------------------------------------------------
[2018-03-01 13:50:52] mark dot scherer at gmx dot de
Yes, using optimization_level=0 also works fine.
Thank you!
------------------------------------------------------------------------
[2018-02-28 22:01:24] nikic@php.net
Looking at the code, my best guess is that we're contracting the assignment for
$shouldBeTextArea into IS_SMALLER and then something eats the NOP, resulting in a smart branch. But
I can't reproduce this. Would be nice to have a self-contained reproducing script for this.
Instead of disabling opcache entirely, it should be enough to set opcache.optimization_level=0 until
this is fixed.
------------------------------------------------------------------------
[2018-02-28 17:19:56] mark dot scherer at gmx dot de
OK, so disabled opcache and all is fine, so this at least limits itself to the opcode cache. We will
keep it disabled for now - but this will sure kill a lot of php applications once deployed.
------------------------------------------------------------------------
[2018-02-28 17:14:44] mark dot scherer at gmx dot de
opcode is on, I will disable and try again
$value = ...;
was a missing line I removed before the "$shouldBeTextArea = mb_strlen($value) > 255;",
but it does not change the result/report.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=76029
--
Edit this bug report at https://bugs.php.net/bug.php?id=76029&edit=1