Bug #76568 [Com]: For loop does not through error when Left bracket does not follow right paren

Edit report at https://bugs.php.net/bug.php?id=76568&edit=1 ID: 76568 Comment by: a at b dot c dot de Reported by: andrew dot marek at sbcglobal dot net Summary: For loop does not through error when Left bracket does not follow right paren Status: Not a bug Type: Bug Package: Scripting Engine problem Operating System: CENTOS 6.4 PHP Version: 5.6.36 Block user comment: N Private report: N New Comment: It's not PHP's fault that your badly-formatted code means you misunderstand what you wrote. spam2 has already pointed out that there is a syntax error in the code you posted (the continue is not inside a loop). If the code you posted came from inside another loop then even that isn't an error. What you wrote is syntactically identical to for($ib = 0; $ib < $ncountp; $ib = $ib + 14) $ib1 = $ib + 1; $ib2 = $ib + 2; $ib3 = $ib + 3; $ib4 = $ib + 4; $ib5 = $ib + 5; $ib6 = $ib + 6; $ib7 = $ib + 7; $ib8 = $ib + 8; $ib9 = $ib + 9; $ib10 = $ib + 10; $ib11 = $ib + 11; $ib12 = $ib + 12; $ib13 = $ib + 13; if(isset($ivcarrp[$ib13])) { if($ivcarrp[$ib13] == "XX") { $bypasscnt++; continue; } } Which is perfectly legitimate syntax. Previous Comments: ------------------------------------------------------------------------ [2018-07-05 20:14:34] andrew dot marek at sbcglobal dot net This is a syntax issue not an indentation issue. If you execute a php statement, say an echo statement and leave of the ending ";" you will get an error like Warning expecting ";" but got ")" so php does do syntax checking. If you are a php person and care about others using this language then this type of check will help others. Personally I don't care, I'm an experienced coder in many languages and come across this stuff all the time. ------------------------------------------------------------------------ [2018-07-03 03:39:05] requinix@php.net We aren't Python. Indentation is not syntax. If you write valid syntax that doesn't do what you want, that's on you. ------------------------------------------------------------------------ [2018-07-02 23:53:36] spam2 at rhsoft dot net and without the continue nobody knows why it is there nothing but an undefined var [harry@srv-rhsoft:/downloads]$ php test.php Notice: Undefined variable: ncountp in /mnt/data/downloads/test.php on line 2 ------------------------------------------------------------------------ [2018-07-02 23:51:03] spam2 at rhsoft dot net this code is simply wrong in supported versions [harry@srv-rhsoft:/downloads]$ php test.php Fatal error: 'continue' not in the 'loop' or 'switch' context in /mnt/data/downloads/test.php on line 12 [harry@srv-rhsoft:/downloads]$ php -v PHP 7.2.7-thelounge-sandybridge (cli) (built: Jul 2 2018 19:28:18) ( NTS ) Copyright (c) 1997-2018 The PHP Group Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies ------------------------------------------------------------------------ [2018-07-02 22:48:20] andrew dot marek at sbcglobal dot net Description: ------------ Note below that the For loop's left bracket does not immediately follow the for loop conditional's right closing bracket. The interpreter does not throw an error and permits this code to execute. Result: For loop does nothing - whether it tries to execute, gets confused, or simply ignores the code - I don't know - the actual result is the program runs and the For loop fails. Fix: Once the interpreter detects a for loop the syntax checker should demand an opening bracket to immediately follow the closing paren on the for loop's conditional. Test script: --------------- for ($ib = 0; $ib < $ncountp; $ib = $ib + 14) $ib1 = $ib + 1; $ib2 = $ib + 2; $ib3 = $ib + 3; $ib4 = $ib + 4; $ib5 = $ib + 5; $ib6 = $ib + 6; $ib7 = $ib + 7; $ib8 = $ib + 8; $ib9 = $ib + 9; $ib10 = $ib + 10; $ib11 = $ib + 11; {$ib12 = $ib + 12; $ib13 = $ib + 13; if (isset($ivcarrp[$ib13])) {if ($ivcarrp[$ib13] == "XX") {$bypasscnt++; continue;} } } ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=76568&edit=1