Bug #76590 [Opn->Fbk]: Using persistent strings as HashTable keys causes heap corruption

Edit report at https://bugs.php.net/bug.php?id=76590&edit=1 ID: 76590 Updated by: nikic@php.net Reported by: dktapps at pmmp dot io Summary: Using persistent strings as HashTable keys causes heap corruption -Status: Open +Status: Feedback Type: Bug Package: Reproducible crash Operating System: * PHP Version: 7.3.0alpha3 Block user comment: N Private report: N New Comment: Placing any kind of persistent entity withing a non-persistent entity (including persistent keys into a non-persistent array) is generally a violation of PHP's memory model. Doing so usually manifests in the form of subtle thread-safety issues caused by non-atomic reference counting. This is also why use of immutablized (persistent) entities is generally legal, as they are not subject to refcounting. Please explain in more detail (and point to the relevant code), where you are using persistent keys in non-persistent hashtables, and why you believe this to be safe. Most likely you either need to use non-persistent strings or ensure that the strings are interned. Previous Comments: ------------------------------------------------------------------------ [2018-07-06 15:38:15] dktapps at pmmp dot io Description: ------------ While attempting to update ext/pthreads (Using the master branch of https://github.com/krakjoe/pthreads) for PHP 7.3.0 alphas, I encountered a range of heap corruption issues. After extensive debugging, I discovered these issues were not caused by pthreads itself. These issues were caused by this commit: https://github.com/php/php-src/commit/5eb1f92f31cafc48384f9096012f421b37f6d425 To be specific, using persistent strings as hashtable keys now causes issues with heap corruption in "zend_array_destroy()" because it now assumes that keys are always non-persistent. pthreads then suffered from issues due to using persistent strings as htable keys for object property tables. I have not further investigated the range of things that this affected. Test script: --------------- <?php $worker = new Worker(); $worker->start(); $worker->stack(new Threaded); $worker->shutdown(); ?> Expected result: ---------------- no output Actual result: -------------- zend_mm_heap corrupted or if in debug mode: Assertion failed: !(zval_gc_flags((s)->gc.u.type_info) & (1<<7)), file c:\php-sdk\php\vc15\x64\php-src\zend\zend_string.h, line 290 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=76590&edit=1