Bug #76574 [Ver->Csd]: use of undeclared identifiers INT_MAX and LONG_MAX

Edit report at https://bugs.php.net/bug.php?id=76574&edit=1 ID: 76574 Updated by: cmb@php.net Reported by: php-bugs-2018 at ryandesign dot com Summary: use of undeclared identifiers INT_MAX and LONG_MAX -Status: Verified +Status: Closed Type: Bug Package: mbstring related Operating System: macOS 10.12.6 PHP Version: 7.3.0alpha2 Assigned To: cmb Block user comment: N Private report: N New Comment: Automatic comment on behalf of cmbecker69@gmx.de Revision: http://git.php.net/?p=php-src.git;a=commit;h=271ae3eb2b142b3ecabe01ebdcc2d29acdd9bc1a Log: Fix #76574: use of undeclared identifiers INT_MAX and LONG_MAX Previous Comments: ------------------------------------------------------------------------ [2018-07-10 06:22:15] php-bugs-2018 at ryandesign dot com Thanks, that patch works for me. ------------------------------------------------------------------------ [2018-07-08 18:38:01] cmb@php.net Sorry, my mistake! When updating the bundled Oniguruma to 6.7.1[1], I've overlooked that it requires limits.h as of Oniguruma 6.4.0. The attached patch should resolve the build failure. [1] <https://github.com/php/php-src/commit/d48b233991c6ae916ca2b7e8d7c965fbc7eb00b7> [2] <https://github.com/kkos/oniguruma/commit/f6db0dde64e4b6a806e52f45307459d433803094> ------------------------------------------------------------------------ [2018-07-08 18:37:43] cmb@php.net The following patch has been added/updated: Patch Name: fix-76574 Revision: 1531075063 URL: https://bugs.php.net/patch-display.php?bug=76574&patch=fix-76574&revision=1531075063 ------------------------------------------------------------------------ [2018-07-05 06:40:30] php-bugs-2018 at ryandesign dot com Yes, I am using php-config73; apologies for the above typo. ------------------------------------------------------------------------ [2018-07-05 06:37:42] ab@php.net Nope, by luck they could have worked, but otherwise there are cases where it depends on the exact paths. In general, it is better to compile in core. Especially it's to see you use 7.2 config but the ticket tells mbstring is from 7.3. The compatibility is not guaranteed. Otherwise, it looks like configure doesn't create config.h for oniguruma or it is wrong in some way, but under this constellation i'm not sure which config is used at all. Please be sure you at least use php-config for 7.3 in first place, oniguruma/src/config.h is created after the configure and include paths point to the correct location. Thanks. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=76574 -- Edit this bug report at https://bugs.php.net/bug.php?id=76574&edit=1