Bug #52974 [Asn->Csd]: jewish.c: compile error under Windows with GBK charset

Edit report at https://bugs.php.net/bug.php?id=52974&edit=1 ID: 52974 Updated by: cmb@php.net Reported by: xiaomao5 at live dot com Summary: jewish.c: compile error under Windows with GBK charset -Status: Assigned +Status: Closed Type: Bug Package: Compile Failure Operating System: Windows 7 PHP Version: 5.3.3 Assigned To: cmb Block user comment: N Private report: N New Comment: Automatic comment on behalf of cmbecker69@gmx.de Revision: http://git.php.net/?p=php-src.git;a=commit;h=99fdf5916eccbd72c10cc4d84693e677996b1229 Log: Fix #52974: jewish.c: compile error under Windows with GBK charset Previous Comments: ------------------------------------------------------------------------ [2013-10-10 09:41:52] xjoywag at 163 dot com My envirement: OS: Windows 7 64bit / Complier: VS 2012 and using 64bit to build PHP I meet the same question when build a php 5.5. Following is the way to issue it: 1. Open VS 2012, open "Files->Open->File", select "jewish.c". 2. Click "Open" button's "down arrow", click "Open Way" 3. In the "Open Way" dialog, select "C++ source editor(with encoding function)" and set it to "default". Click "OK". 4. Now, pop a new encoding dialog showing "auto-check" option. 5. Click "down arrow" to show all options and select "Hebrew(Windows) - code page 1255". Click button "OK". 6. Ok, the file is opened no any prompt and can find those Hebrew words. 7. let's do the most important operation. Open "Files->Advanced Save Options". 8. Now, select "Unicode - code page 1200" from Encoding dialog. Click "OK". 9. I think none want to edit this file next, so open "Files->Save" or "Ctrl+S" ( and close VS). buildconf --force, configure ..., nmake again :) maybe should delete Release-TS too. Sorry, I use Chinese VS 2012, so translate menus/dialogs to English for comment. ------------------------------------------------------------------------ [2013-05-16 19:43:04] aharvey@php.net Reopening. GBK seems to be a common theme here, and line 326 includes ISO-8859-8 encoded Hebrew which iconv suggests is invalid in GBK. ------------------------------------------------------------------------ [2013-05-10 09:13:02] zhaoyong dot lc at gmail dot com I find this problem too in PHP 5.3.17, I want to complie PHP in Windows but error "jewish.c(324) : error C2001" is throwed out. My OS is Windows 7 with GBK character set and Compiler is Visual Studio 2008. It also can't be corrent by changing encoding and character set. ------------------------------------------------------------------------ [2013-02-18 00:34:30] php-bugs at lists dot php dot net No feedback was provided. The bug is being suspended because we assume that you are no longer experiencing the problem. If this is not the case and you are able to provide the information that was requested earlier, please do so and change the status of the bug back to "Open". Thank you. ------------------------------------------------------------------------ [2011-03-21 06:17:30] zhangsilly at gmail dot com this problem is still in PHP 5.3.6. The same problem is in ext/standard/browscap.c, in the line 61. My OS is Windows 7 & Windows XP.Compiler is Visual Studio 2008.But , I think is not matter with compiler, when i use Editplus to view these files, Thy cann't show correct,not matter i choose the encoding with ANSI/GBK or UTF-8. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=52974 -- Edit this bug report at https://bugs.php.net/bug.php?id=52974&edit=1