Bug #70580 [ReO]: Test Zend/tests/bug42143.phpt is broken

Edit report at https://bugs.php.net/bug.php?id=70580&edit=1 ID: 70580 Updated by: yohgaki@php.net Reported by: rainer dot jung at kippdata dot de Summary: Test Zend/tests/bug42143.phpt is broken Status: Re-Opened Type: Bug Package: Testing related Operating System: Solaris PHP Version: 7.0.0RC3 Assigned To: carusogabriel Block user comment: N Private report: N New Comment: How about ignore the test on Solaris by using PHP_OS constant. i.e. Use SKIPIF Skipping all tests in the .phpt is nonsense, so create new .phpt and move offending tests to it. I guess PHP_OS would be "Solaris". I don't have solaris. Someone using solaris should write phpt and test it. Previous Comments: ------------------------------------------------------------------------ [2018-08-05 16:43:38] carusogabriel@php.net @cmb My apologies, I didn't pay attention to that detail. I'll try to emulate Solaris locally and see if we can fix, or drop those lines as suggested. Btw, thanks for the Wiki Systems link (https://wiki.php.net/systems), I didn't know about it. ------------------------------------------------------------------------ [2018-08-05 14:20:19] cmb@php.net gcov.php.net runs on CentOS 6[1], so the test is likely to succeed. The report is about the test failing on Solaris, which still might be the case. I agree with Rainer, that the two lines should be dropped. Kalle's argument to keep the lines for better code coverage is somewhat moot, since our log() and log10() implementations are thin wrappers over C's log() and log10(), respectively, so basically we're testing implementation defined behavior here. [1] <https://wiki.php.net/systems/nex2> ------------------------------------------------------------------------ [2018-08-05 05:00:40] carusogabriel@php.net Closing as this tests isn't failing anymore: http://gcov.php.net/viewer.php?version=PHP_HEAD&func=tests ------------------------------------------------------------------------ [2015-10-24 04:48:25] kalle@php.net Now its been a while with proper testing writing, but I think its possible that we change the EXPECT section to EXPECTF and then have something like: %NaN|INF% or similar, I should probably consult run-tests.php for this, but it seems most reasonable we keep the test for most code path coverage. ------------------------------------------------------------------------ [2015-09-25 12:05:16] rainer dot jung at kippdata dot de This applies also to PHP 5.4-5.6 (latest releases). ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=70580 -- Edit this bug report at https://bugs.php.net/bug.php?id=70580&edit=1