Req #67331 [Csd->ReO]: Have parse_ini_file add empty entries
| From: | cmb@php.net | Date: | Sat, 15 Sep 2018 15:26:28 +0000 |
| Subject: | Req #67331 [Csd->ReO]: Have parse_ini_file add empty entries | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-217069@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=67331&edit=1
ID: 67331
Updated by: cmb@php.net
Reported by: philip@php.net
Summary: Have parse_ini_file add empty entries
-Status: Closed
+Status: Re-Opened
Type: Feature/Change Request
Package: *Configuration Issues
PHP Version: 5.6.0beta3
Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
I have reverted the commit for now, since it broke some tests on
Windows. Strangely, these tests appear to succeed on Linux.
Anyhow, changing the NULL to an empty string lets the tests
succeed on Windows. Considering strict typing, setting entries
without equal sign to an empty string might be better anyway
(that's also done this way by Python).
But there are more issues. Firstly, run-tests.php is not prepared
for entries without equal sign[1]. Secondly, the
-d option of
the CLI php (I have not yet checked other SAPIs) seems to
interpret options without equal sign as enabling them[2], which
would be inconsistent. Changing this, however, would be a
considerable BC break.
[1] <https://github.com/php/php-src/blob/php-7.3.0RC1/run-tests.php#L2378-L2395>
[2] <https://github.com/php/php-src/blob/php-7.3.0RC1/sapi/cli/php_cli.c#L1303-L1308>
Previous Comments:
------------------------------------------------------------------------
[2018-09-15 15:12:45] cmb@php.net
Automatic comment from SVN on behalf of cmb
Revision: http://svn.php.net/viewvc/?view=revision&revision=345643
Log: Revert revision(s) 345642 from phpdoc/en/trunk:
Update regarding implemented feature request #67331
------------------------------------------------------------------------
[2018-09-15 14:05:12] cmb@php.net
Automatic comment from SVN on behalf of cmb
Revision: http://svn.php.net/viewvc/?view=revision&revision=345642
Log: Update regarding implemented feature request #67331
------------------------------------------------------------------------
[2018-09-15 14:01:51] cmb@php.net
The PR has been applied[1] â closing.
[1] <http://git.php.net/?p=php-src.git;a=commit;h=3f3e914df33793a36f51b4e44745d6a5aec4f685>
------------------------------------------------------------------------
[2018-08-28 15:39:14] cmb@php.net
<https://github.com/php/php-src/pull/3473>
submitted.
------------------------------------------------------------------------
[2014-07-03 23:10:43] philip@php.net
Automatic comment from SVN on behalf of philip
Revision: http://svn.php.net/viewvc/?view=revision&revision=334105
Log: Mention that entries without an equal sign are ignored. Recent feature request PHP Bug #67331
requests this functionality.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=67331
--
Edit this bug report at https://bugs.php.net/bug.php?id=67331&edit=1