Bug #47955 [Opn->Nab]: ReflectionClass::newInstanceArgs() fails with references
| From: | nikic@php.net | Date: | Tue, 02 Oct 2018 16:36:55 +0000 |
| Subject: | Bug #47955 [Opn->Nab]: ReflectionClass::newInstanceArgs() fails with references | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-217366@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=47955&edit=1
ID: 47955
Updated by: nikic@php.net
Reported by: richardcook at gmail dot com
Summary: ReflectionClass::newInstanceArgs() fails with
references
-Status: Open
+Status: Not a bug
Type: Bug
Package: Reflection related
Operating System: *
PHP Version: 5.*, 6CVS (2009-05-14)
Block user comment: N
Private report: N
New Comment:
The current behavior here is correct and intended. As mentioned, you need to use references in the
array to allow this to work in any reasonable fashion.
Since PHP 7.1 the call will be performed despite the reference warnings, though this may be
tightened again in the future.
Previous Comments:
------------------------------------------------------------------------
[2009-05-21 16:37:37] lbarnaud@php.net
It works when the elements of the array are references:
$reflectionClass->newInstanceArgs(array(&$this, &$this->arr));
------------------------------------------------------------------------
[2009-04-13 17:52:58] jani@php.net
<?php
class Foo {
function __construct (&$arr) {
$this->arr = &$arr;
}
function createInstance () {
$reflectionClass = new ReflectionClass("Bar");
return $reflectionClass->newInstanceArgs(array($this, $this-
>arr));
}
function mod($key, $val) {
$this->arr[$key] = $val;
}
}
class Bar {
function __construct (&$foo, &$arr) {
$this->foo = &$foo;
$this->arr = &$arr;
}
function mod($key, $val) {
$this->arr[$key] = $val;
}
}
$arr = array();
$foo = new Foo($arr);
$arr["x"] = 1;
$foo->mod("y", 2);
$bar = $foo->createInstance();
$bar->mod("z", 3);
var_dump($arr,$foo,$bar);
?>
------------------------------------------------------------------------
[2009-04-12 21:54:42] richardcook at gmail dot com
Description:
------------
ReflectionClass::newInstanceArgs throws a constructor fail warning
and does not create the class if the class' constructor has variable
references in it
Reproduce code:
---------------
http://pastebin.com/f4a147910
Expected result:
----------------
Array
(
[x] => 1
[y] => 2
[z] => 3
)
Foo Object
(
[arr] => Array
(
[x] => 1
[y] => 2
[z] => 3
)
)
Bar Object
(
[foo] => Foo Object
(
[arr] => Array
(
[x] => 1
[y] => 2
[z] => 3
)
)
[arr] => Array
(
[x] => 1
[y] => 2
[z] => 3
)
)
Actual result:
--------------
Warning: Invocation of Bar's constructor failed in [code path] on
line 9
Fatal error: Call to a member function mod() on a non-object in [code
path] on line 36
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=47955&edit=1