Bug #76889 [Ver->Csd]: checkdnsrr.phpt fails because bugs.php.net doesn't have all 12 DNS records
| From: | pmmaga@php.net | Date: | Sat, 06 Oct 2018 14:56:11 +0000 |
| Subject: | Bug #76889 [Ver->Csd]: checkdnsrr.phpt fails because bugs.php.net doesn't have all 12 DNS records | ||
| References: | 1 | Groups: | php.bugs php.qa |
| Request: | Send a blank email to php-bugs+get-217448@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=76889&edit=1
ID: 76889
Updated by: pmmaga@php.net
Reported by: spam2 at rhsoft dot net
Summary: checkdnsrr.phpt fails because bugs.php.net doesn't
have all 12 DNS records
-Status: Verified
+Status: Closed
Type: Bug
Package: Testing related
Operating System: Fedora 28
PHP Version: 7.2Git-2018-09-16 (Git)
-Assigned To:
+Assigned To: pmmaga
Block user comment: N
Private report: N
New Comment:
The fix for this bug has been committed.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
The unstable test was removed.
Previous Comments:
------------------------------------------------------------------------
[2018-10-05 00:14:29] pmmaga@php.net
I've opened a PR switching it to use php.net and matching the currently existing records. https://github.com/php/php-src/pull/3577
------------------------------------------------------------------------
[2018-09-16 15:27:08] spam2 at rhsoft dot net
> Thanks for reporting this months ago when you first saw it was broken
don't get me wrong but i thought the php-developers are running their test-suite regulary at
their own and look at every faling test as i do all the time with my tests
------------------------------------------------------------------------
[2018-09-16 15:24:06] requinix@php.net
Thanks for reporting this months ago when you first saw it was broken.
checkdnsrr is working fine but it's testing against bugs.php.net which doesn't have all
the record types it wants. I checked a few big name domains and they too generally have about half
of them. I did find ipv6.comcast.net had all 12, but it wouldn't be fair to borrow their
domain.
I think the answer here is taking some php.net domain, like bugs.php.net or some new subdomain, and
just giving it all these records purely for the sake of testing. Could be in Jan 2017 when the test
was first added that it did have everything, but apparently not anymore.
------------------------------------------------------------------------
[2018-09-16 14:27:50] spam2 at rhsoft dot net
Description:
------------
FAILED TEST SUMMARY
---------------------------------------------------------------------
bool checkdnsrr ( string $host [, string $type = "MX" ] );
[ext/standard/tests/checkdnsrr.phpt]
that test now fails for months - why do such issues not get fixed or non-working tests not disabled
so that it's easier for the maintainers to fix remaining ones?
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=76889&edit=1