Bug #76839 [Opn->Csd]: socket_recvfrom may return an invalid 'from' address on MacOS
| From: | ab@php.net | Date: | Wed, 26 Dec 2018 19:22:03 +0000 |
| Subject: | Bug #76839 [Opn->Csd]: socket_recvfrom may return an invalid 'from' address on MacOS | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-218628@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=76839&edit=1
ID: 76839
Updated by: ab@php.net
Reported by: michael at meyer dot io
Summary: socket_recvfrom may return an invalid 'from' address
on MacOS
-Status: Open
+Status: Closed
Type: Bug
Package: Sockets related
Operating System: macOS 10.14
PHP Version: 7.2.9
-Assigned To:
+Assigned To: ab
Block user comment: N
Private report: N
New Comment:
The PR has been merged.
Thanks!
Previous Comments:
------------------------------------------------------------------------
[2018-09-04 17:43:17] michael at meyer dot io
Description:
------------
On MacOS 10.14 w/PHP 7.2.9, socket_recvfrom is returning invalid 'from' addresses which
have trailing garbage bytes at the end.
This makes it impossible to respond with socket_sendto unless you know what the correct
'from' address should be.
I created a pull request for this bug on GitHub: https://github.com/php/php-src/pull/3408
Test script:
---------------
<?php
for ($i = 0; $i < 10; $i++) {
$senderSocketPath = '/tmp/' . substr(md5(rand()), 0, rand(8, 16)) . '.sock';
$senderSocket = socket_create(AF_UNIX, SOCK_DGRAM, 0);
socket_bind($senderSocket, $senderSocketPath);
$receiverSocketPath = '/tmp/' . substr(md5(rand()), 0, rand(8, 16)) .
'.sock';
$receiverSocket = socket_create(AF_UNIX, SOCK_DGRAM, 0);
socket_bind($receiverSocket, $receiverSocketPath);
// Send message from socket 1 to socket 2
socket_sendto($senderSocket, 'Ping!', 5, 0, $receiverSocketPath);
// Receive & respond to message on socket 2
$from = '';
$message = '';
socket_recvfrom($receiverSocket, $message, 65535, 0, $from);
echo "Received '$message'\n";
// Respond to the sender using the 'from' address from socket_recvfrom
socket_sendto($receiverSocket, 'Pong!', 5, 0, $from);
echo "Responded to sender with 'Pong!'\n";
socket_close($receiverSocket);
unlink($receiverSocketPath);
socket_close($senderSocket);
unlink($senderSocketPath);
}
Expected result:
----------------
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Actual result:
--------------
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
PHP Warning: socket_sendto(): unable to write to socket [2]: No such file or directory in <test
script> on line 22
Warning: socket_sendto(): unable to write to socket [2]: No such file or directory in <test
script> on line 22
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
PHP Warning: socket_sendto(): unable to write to socket [2]: No such file or directory in <test
script> on line 22
Warning: socket_sendto(): unable to write to socket [2]: No such file or directory in <test
script> on line 22
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
Received 'Ping!'
Responded to sender with 'Pong!'
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=76839&edit=1