Bug #77330 [Asn]: session_id() no longer works inside custom SessionHandlerInterface

Edit report at https://bugs.php.net/bug.php?id=77330&edit=1 ID: 77330 Updated by: nikic@php.net Reported by: e6990620 at gmail dot com Summary: session_id() no longer works inside custom SessionHandlerInterface Status: Assigned Type: Bug Package: Session related Operating System: Linux PHP Version: 7.3.0 Assigned To: yohgaki Block user comment: N Private report: N New Comment: @yohgaki: I'm not sure I see what strict mode has to do with this. This change has been introduced in https://github.com/php/php-src/pull/2406. It's a new check, independent of strict mode. Previous Comments: ------------------------------------------------------------------------ [2019-01-17 10:01:34] yohgaki@php.net Unless someone changed code and test, there is strict_mode phpt so I suppose stict_mode is not broken. Reporter, please verify. ------------------------------------------------------------------------ [2019-01-17 09:53:09] yohgaki@php.net While I've been proposed enabling stricrt_mode by default, but it's not enabled yet. Current implementation requires 2 session data read when strict mode is enabled, but this can be save to 1 read. This is rather simple change, but it requires save handler API change. ------------------------------------------------------------------------ [2019-01-17 09:50:23] yohgaki@php.net Your PHP 7.2 is enabling session.strict_mode=On while 7.3 is not. ------------------------------------------------------------------------ [2019-01-02 09:09:59] nikic@php.net Maybe we should revert this change for now? Until someone with good ext/session understanding can look at this, I think it's okay to just drop the warning in the meantime. ------------------------------------------------------------------------ [2018-12-21 15:05:36] cmb@php.net This behavioral change has been introduced by merging pull request 2406[1]. Yasuo, can you please have a look at this? There will also be a warning, if the session ID is changed in SessionHandlerInterface::open(). [1] <https://github.com/php/php-src/pull/2406> ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=77330 -- Edit this bug report at https://bugs.php.net/bug.php?id=77330&edit=1