Bug #77535 [Opn]: Invalid callback, h2 server push

Edit report at https://bugs.php.net/bug.php?id=77535&edit=1 ID: 77535 User updated by: tobias dot nyholm at gmail dot com Reported by: tobias dot nyholm at gmail dot com Summary: Invalid callback, h2 server push Status: Open Type: Bug Package: cURL related PHP Version: master-Git-2019-01-28 (Git) Block user comment: N Private report: N New Comment: Using a callback like "[$this, '_callback']" does not work. I did manage to declare a global function foobar() and use "foobar" as callback. But that seams suboptimal. Previous Comments: ------------------------------------------------------------------------ [2019-01-28 21:12:28] pmmaga@php.net IIRC, and according to the warning, the current implementation is only accepting callables but not Closures. If you make the callback as a named function it should be possible to set it up. ------------------------------------------------------------------------ [2019-01-28 21:05:36] tobias dot nyholm at gmail dot com Btw, You can test this with this repo: https://github.com/Nyholm/php-test-server-push There is a test called "test77535.php" ------------------------------------------------------------------------ [2019-01-28 20:53:38] tobias dot nyholm at gmail dot com Interesting. If I don't use a variable and I set CURLMOPT_PUSHFUNCTION in sendRequest() then I also get the warning. ------------------------------------------------------------------------ [2019-01-28 20:41:21] requinix@php.net What about if you have the code in sendRequest and use curl_multi_setopt($this->mh, CURLMOPT_PUSHFUNCTION, static function () { return CURL_PUSH_OK; }); without putting the callback into a variable? ------------------------------------------------------------------------ [2019-01-28 19:21:58] tobias dot nyholm at gmail dot com Description: ------------ When I set my callback in a different function I get a warning. I cannot figure out why. If I move the contents of addServerPushCallback() to sendRequest() then I wont have the same issue. Test script: --------------- <?php class MyHttpClient { private $mh; private $curl; public function sendRequest() { if (false === $this->mh = curl_multi_init()) { throw new \RuntimeException('Unable to create a new cURL multi handle'); } // FIXME Using a function like this does not work. If we inline the contents of addServerPushCallback(), then we got no problem $this->addServerPushCallback(); $this->curl = curl_init(); curl_setopt($this->curl, CURLOPT_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS); curl_setopt($this->curl, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS); curl_setopt($this->curl, CURLOPT_HEADER, false); curl_setopt($this->curl, CURLOPT_RETURNTRANSFER, false); curl_setopt($this->curl, CURLOPT_FAILONERROR, false); curl_setopt($this->curl, CURLOPT_URL, 'https://http2.golang.org/serverpush'); curl_setopt($this->curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_0); curl_setopt($this->curl, CURLOPT_HEADERFUNCTION, function ($ch, $data) { return \strlen($data); }); curl_setopt($this->curl, CURLOPT_WRITEFUNCTION, function ($ch, $data) { return \strlen($data); }); curl_multi_add_handle($this->mh, $this->curl); $stillRunning = null; while (true) { do { $mrc = curl_multi_exec($this->mh, $stillRunning); } while (CURLM_CALL_MULTI_PERFORM === $mrc); $info = curl_multi_info_read($this->mh); while (false !== $info && $info['msg'] == CURLMSG_DONE) { if (CURLMSG_DONE !== $info['msg']) { continue; } die("Start handle request. "); } } } private function addServerPushCallback(): void { $callback = static function () { return CURL_PUSH_OK; }; curl_multi_setopt($this->mh, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX); curl_multi_setopt($this->mh, CURLMOPT_PUSHFUNCTION, $callback); } } $buzz = new MyHttpClient(); $buzz->sendRequest(); Expected result: ---------------- Output only "Start handle request." Actual result: -------------- Warning: Invalid callback , no array or string given in /usr/src/myapp/test.php on line 40 Warning: curl_multi_exec(): Cannot call the CURLMOPT_PUSHFUNCTION in /usr/src/myapp/test.php on line 40 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=77535&edit=1