Bug #58319 [Opn]: OCI-LOB invalid character in Class name

Edit report at https://bugs.php.net/bug.php?id=58319&edit=1 ID: 58319 Updated by: nikic@php.net Reported by: kevinpgrant at yahoo dot co dot uk Summary: OCI-LOB invalid character in Class name Status: Open Type: Bug Package: OCI8 related Operating System: linux PHP Version: 5.2.5 Block user comment: N Private report: N New Comment: @tandre: Sounds good to me. I'd suggest renaming the class to OCI_Lob and making OCI-Lob the alias though, to make everything use the new class name (while still being compatible with OCI-Lob, if someone goes out of the way to use it). Previous Comments: ------------------------------------------------------------------------ [2019-02-17 00:14:35] tandre@php.net I'd be in favor of doing the following: 1. Add OCI_Lob as an internal class alias of OCI-Lob in PHP 7.4 and documenting that 2. Dropping the original OCI-Lob name in PHP 8.0 3. Forbidding internal extensions from registering class names that would be impossible for PHP code to do, in PHP 8.0 (e.g. hyphens, starting with numbers, etc) It seems doable - zend_register_class_alias("_ZendTestClassAlias", zend_test_class); seems to do that in ext/zend_test/test.c Same for OCI-Collection/OCI_Collection, etc. There are several reasons for making this change: 1. The classes from OCI can't be type hinted in PHP programs for param/return types in the signature, as mentioned earlier 2. This makes uses of those class difficult to statically analyze, and will make any tools performing sanity checks of class names from Reflection fail. See https://github.com/phan/phan/issues/2222 and https://github.com/phan/PHPSignatures/pull/3#discussion_r246262546 3. The workarounds used by static analyzers and IDEs may mislead users into thinking that $x instanceof OCI_Collection will work properly, making bugs more likely ------------------------------------------------------------------------ [2016-10-28 03:41:32] m at ahungry dot com When using PHP7, how can this class be type hinted? I think this class should be renamed to OCI_Lob instead of OCI-Lob to maintain standard naming conventions. ------------------------------------------------------------------------ [2015-10-12 18:44:13] ashnazg@php.net "if (is_a($clob, 'OCI-LOB')) {" is working fine for me (PHP 5.5.24)... should this bug be closed? ------------------------------------------------------------------------ [2013-01-03 22:53:30] r dot ejem at seznam dot cz I don't see type-checking pointless especially in PHP which has poor to no compile-time type-checking. I think this bug should be fixed in future version. Invalid class name of a built-in class is, I think, a terrible mistake, which has to be definitely fixed. ------------------------------------------------------------------------ [2008-08-19 06:40:59] tony at daylessday dot org // check $clob is of type 'OCI-Lob' here It's pointless to check it because oci_new_descriptor() can return only two things - NULL and OCI-Lob class instance. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=58319 -- Edit this bug report at https://bugs.php.net/bug.php?id=58319&edit=1