Bug #76345 [Com]: fatal error: zip.h: No such file or directory

Edit report at https://bugs.php.net/bug.php?id=76345&edit=1 ID: 76345 Comment by: mnikulin at plesk dot com Reported by: tholforty at gmail dot com Summary: fatal error: zip.h: No such file or directory Status: Open Type: Bug Package: Compile Failure Operating System: CentOS 7.4 PHP Version: 7.2.5 Block user comment: N Private report: N New Comment: The issue may be worse if incompatible zip.h presents in search path, e.g. old version installed as a system package to /usr/include. Different alignment of structure fields might potentially lead to crashes. Fortunately it seems that no declarations from zip.h is used outside of ext/zip. The patch attached earlier looks malformed. In my opinion zip.h belongs to implementation details, so should not be used outside of ext/zip, so php_zip.h should be split into public and internal parts. Minimal workaround without modification of php_zip.h is Index: configure.ac =================================================================== --- configure.ac.orig +++ configure.ac @@ -1525,8 +1525,8 @@ PHP_ADD_SOURCES(main/streams, streams.c plain_wrapper.c userspace.c transports.c xp_socket.c mmap.c \ glob_wrapper.c, -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1) -PHP_ADD_SOURCES(/main, internal_functions.c, -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1, sapi) -PHP_ADD_SOURCES_X(/main, internal_functions_cli.c, -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1, PHP_BINARY_OBJS) +PHP_ADD_SOURCES(/main, internal_functions.c, [-DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 $LIBZIP_CFLAGS], sapi) +PHP_ADD_SOURCES_X(/main, internal_functions_cli.c, [-DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 $LIBZIP_CFLAGS], PHP_BINARY_OBJS) PHP_ADD_SOURCES(Zend, \ zend_language_parser.c zend_language_scanner.c \ Previous Comments: ------------------------------------------------------------------------ [2019-01-30 13:36:58] tholforty at gmail dot com the patch provided should fix it. it is patching ext/zip/libzip_config.m4. it is simply adding PHP_ADD_INCLUDE macro in a couple places to make sure the compiler looks in the custom specified place first. ------------------------------------------------------------------------ [2019-01-30 02:39:15] han at 163 dot com Me too. What should I do? ------------------------------------------------------------------------ [2018-06-14 08:00:47] imoco at qq dot com me too,my php version:7.2.6 os:centos 7.5 ------------------------------------------------------------------------ [2018-05-16 07:08:37] tholforty at gmail dot com Changed to compile failure, since it is not an issue with PECL:Zip ------------------------------------------------------------------------ [2018-05-15 21:57:50] tholforty at gmail dot com Description: ------------ the config.m4 make config file is missing the PHP_ADD_INCLUDE() macro. This is an issue with all versions that include --with-libzip=DIR from v5.6 to v7.2 I'm building multiple php versions on the server and do not have any intention of working with the base yum installed version. As such I didn't install the libzip-devel package that puts headers (albeit old ones) into the system include. I compiled libzip into /opt/libzip and used --with-libzip=/opt/libzip for the php compile. That is how I ran into the issue. As a control, php compiles just fine without the libtidy-devel package installed and specifying --with-tidy=/opt/libtidy. With the setup in ext/zip/config.m4 as is, make will look for zip.h in the system /usr/include and not in the include of the directory specified in --with-libzip=DIR. Without a system level installation of zip.h, this error occurs during make: In file included from main/internal_functions_cli.c:36:0: /usr/local/src/git-php72-build/php-src/ext/zip/php_zip.h:31:17: fatal error: zip.h: No such file or directory #include <zip.h> ^ compilation terminated. make: *** [main/internal_functions_cli.lo] Error 1 Test script: --------------- So without a system level installation of zip.h the following will fail during make with: fatal error: zip.h: No such file or directory ./configure \ --prefix=/opt/php72 \ --enable-zip \ --with-libzip=/opt/libzip \ --with-zlib && make Expected result: ---------------- In file included from main/internal_functions_cli.c:36:0: /usr/local/src/git-php72-build/php-src/ext/zip/php_zip.h:31:17: fatal error: zip.h: No such file or directory #include <zip.h> ^ compilation terminated. make: *** [main/internal_functions_cli.lo] Error 1 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=76345&edit=1