Bug #77980 [Com]: why remove --disable-opcache-filecache

Edit report at https://bugs.php.net/bug.php?id=77980&edit=1 ID: 77980 Comment by: spam2 at rhsoft dot net Reported by: spam2 at rhsoft dot net Summary: why remove --disable-opcache-filecache Status: Not a bug Type: Bug Package: opcache PHP Version: Next Major Version Block user comment: N Private report: N New Comment: around 20% with a highly optimized PGO build as far as i remember Previous Comments: ------------------------------------------------------------------------ [2019-05-07 11:31:55] nikic@php.net Please provide specific numbers for the significant size increases you are seeing, as well as which compile options they were produced under. ------------------------------------------------------------------------ [2019-05-07 11:12:24] spam2 at rhsoft dot net it makes a significant part of the opcache.so binary and testing these days is the job of a computer and not humans we use that option since it exists *because* it makes opcache.so significant smaller and it was never broken except maybe PHP7.3 which is curently out-of-scope here given the large amout of bugs which slowly go in a direction to call it "stable" ------------------------------------------------------------------------ [2019-05-07 11:08:32] nikic@php.net Because nobody ever tests the --disable-opcache-filecache build and IIRC it was broken at the time due to a missing #ifdef. A marginally smaller binary is not a reason to keep around this option. This does not make up any significant part of the binary. ------------------------------------------------------------------------ [2019-05-07 11:02:05] spam2 at rhsoft dot net Description: ------------ how does the fact that something is no longer experimental justify bloated binaries with unused code? frankly i don't want having "systemctl reload httpd" not clear the opcache and i don't want bloatet binaries if you want to to do something useful move the core into a loadable so-file instead have it twice in /usr/bin/php and /usr/lib64/httpd/modules/libphp7.so and make both a tiny shim-loader ---------------------- http://git.php.net/?p=php-src.git;a=commitdiff;h=c32da66e129897f4f103ecc6319332f160ee52ea Remove --disable-opcache-filecache option This is no longer an experimental feature, and we have the ability to control this at runtime via an ini setting. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=77980&edit=1