Bug #78185 [Asn->Csd]: File cache no longer works

Edit report at https://bugs.php.net/bug.php?id=78185&edit=1 ID: 78185 Updated by: dmitry@php.net Reported by: cmb@php.net Summary: File cache no longer works -Status: Assigned +Status: Closed Type: Bug Package: opcache Operating System: Windows PHP Version: 7.3.7RC2 Assigned To: dmitry Block user comment: N Private report: N New Comment: Automatic comment on behalf of dmitry@zend.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=cd6a6e4cf2677bfbe2a21164239737eb22bd4da6 Log: Fixed bug #78185 (File cache no longer works) Previous Comments: ------------------------------------------------------------------------ [2019-06-20 05:48:15] krakjoe@php.net I think the last patch (made against 7.4) looks more correct ... ------------------------------------------------------------------------ [2019-06-20 05:47:31] krakjoe@php.net The following patch has been added/updated: Patch Name: file-cache-fix.patch Revision: 1561009651 URL: https://bugs.php.net/patch-display.php?bug=78185&patch=file-cache-fix.patch&revision=1561009651 ------------------------------------------------------------------------ [2019-06-20 05:40:06] krakjoe@php.net I don't fully understand why that seems to fix it, and don't understand why reverting the original change doesn't seem to fix it. Assigning to dmitry ... ------------------------------------------------------------------------ [2019-06-20 05:14:54] krakjoe@php.net Try this (patch probably won't apply on 7.3 branch) ... diff --git a/ext/opcache/ZendAccelerator.c b/ext/opcache/ZendAccelerator.c index 85e0de94dd..52eab0d775 100644 --- a/ext/opcache/ZendAccelerator.c +++ b/ext/opcache/ZendAccelerator.c @@ -2315,7 +2315,7 @@ int accel_activate(INIT_FUNC_ARGS) ZCG(cwd_check) = 1; if (file_cache_only) { - ZCG(accelerator_enabled) = 0; + ZCG(accelerator_enabled) = 1; return SUCCESS; } I'm pretty sure that's the problem ... ------------------------------------------------------------------------ [2019-06-20 04:52:23] krakjoe@php.net This looks highly suspect: @@ -2342,6 +2360,7 @@ static void accel_activate(void) #ifdef HAVE_OPCACHE_FILE_CACHE if (file_cache_only) { + ZCG(accelerator_enabled) = 0; return; } #endif extracted from diff of the two tags ... ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=78185 -- Edit this bug report at https://bugs.php.net/bug.php?id=78185&edit=1