Bug #78349 [Opn]: Bundled pcre2 library missing LICENCE file

Edit report at https://bugs.php.net/bug.php?id=78349&edit=1 ID: 78349 User updated by: rainer dot jung at kippdata dot de Reported by: rainer dot jung at kippdata dot de Summary: Bundled pcre2 library missing LICENCE file Status: Open Type: Bug Package: PCRE related Operating System: Any PHP Version: 7.4.0beta1 Block user comment: N Private report: N New Comment: Ah, had not seen that. For me the licence was the critical file. I think the other files are less critial. I don't know what mechanism is used to sync the bundled pcre2 lib with upstreams. It might be easy to include those files in the sync (if it is not done manually). But if you like you can also close this ticket. Thanks! Previous Comments: ------------------------------------------------------------------------ [2019-07-29 15:27:53] cmb@php.net The license is already contained in README.REDIST.BINS[1]. Not sure what to do regarding the other files. [1] <https://github.com/php/php-src/blob/php-7.4.0beta1/README.REDIST.BINS#L23-L116> ------------------------------------------------------------------------ [2019-07-29 14:56:29] rainer dot jung at kippdata dot de Description: ------------ In PHP 7.3 and 7.4 the bundled pcrelib was updated from PCRE 1 to PCRE 2. When updating, all non-code files were dropped, expecially the LICENCE file. I think it would be better to add the upstream PCRE 2 LICENCE file back and maybe also the other ones: AUTHORS ChangeLog COPYING HACKING INSTALL LICENCE NEWS NON-AUTOTOOLS-BUILD README doc The loss might be due to the fact, that in PCRE 1 source file were located in the top directory, just as these accompanying files, in PCRE 2 they are located in a sub folder "src", so just syncing the src folder misses the accompanying files. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=78349&edit=1