Bug #42 [PATCH]: convert program dies on certain comments

Edit report at https://bugs.php.net/bug.php?id=42&edit=1 ID: 42 Patch added by: curtiswrutzinger@icloud.com Reported by: a dot hacker at clear dot net dot nz Summary: convert program dies on certain comments Status: Closed Type: Bug Package: Other Operating System: Win32 PHP Version: 3.0b4 Block user comment: N Private report: N New Comment: The following pull request has been associated: Patch Name: Fix #78429: opcache_compile_file(__FILE__); segfaults On GitHub: https://github.com/php/php-src/pull/4570 Patch: https://github.com/php/php-src/pull/4570.patch Previous Comments: ------------------------------------------------------------------------ [1998-02-06 12:59:28] zeev PHP/FI 2 accepted this, although IMHO it shouldn't have. The convertor 'eats' the comment, and is left with a semicolon. Since empty statements weren't valid in PHP/FI 2, the convertor rejects that code. It's possible to fix this specific issue, but it has potential to break other things, so I'd rather not do it... ------------------------------------------------------------------------ [1998-02-06 04:27:57] a dot hacker at clear dot net dot nz Small niggly problem but I was converting a script I stumbled across and ran it through the PHP3->3 converter. The converter died on comments ending in semi-colons like this /* this is a comment */ ; Don't know if it's a valid thing or just poor scripting but I thought I'd point it out. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=42&edit=1