Bug #78460 [Asn]: PEAR installation failure

Edit report at https://bugs.php.net/bug.php?id=78460&edit=1 ID: 78460 User updated by: l dot declercq at nuxwin dot com Reported by: l dot declercq at nuxwin dot com Summary: PEAR installation failure Status: Assigned Type: Bug Package: *General Issues Operating System: debian PHP Version: 7.4.0beta4 Assigned To: petk Block user comment: N Private report: N New Comment: @petk To fix the problem, I had to patch as follow: --- a/configure.ac +++ b/configure.ac @@ -1550,6 +1550,7 @@ AC_DEFINE([HAVE_BUILD_DEFS_H], 1, [ ]) +$php_shtool mkdir -p pear $php_shtool mkdir -p scripts $php_shtool mkdir -p scripts/man1 Previous Comments: ------------------------------------------------------------------------ [2019-08-28 02:33:37] l dot declercq at nuxwin dot com petk@php.net I've explained you already. When you build in a subdirectory (build directory), and if the pear directory isn't create in that directory, the pear installation will fail in case the pear/install-pear-nozlib.phar has been provided in the top build directory. Basically, when I build, I've the following: root@phpswitcher:/# tree /usr/local/src/phpswitcher/php-7.4.0beta4/pear/ /usr/local/src/phpswitcher/php-7.4.0beta4/pear/ ├── fetch.php ├── install-pear-nozlib.phar ├── install-pear.txt └── Makefile.frag 0 directories, 4 files On that, we agreed together. But my build is done in a subdirectory, that is: /usr/local/src/phpswitcher/php-7.4.0beta4/7.4-build and if the pear directory isn't created inside the /usr/local/src/phpswitcher/php-7.4.0beta4/7.4-build build directory (past behavior), the PEAR installation will fail, at least when the install-pear-nozlib.phar is part of the release. ------------------------------------------------------------------------ [2019-08-28 02:26:36] petk@php.net Then I am not sure what is the issue here. Can you explain and talk about the issue or send a pull request? The PHP-7.4.0beta4 package downloaded from https://downloads.php.net/~derick/ includes this phar PEAR installation file at pear/install-pear-nozlib.phar so no additional files are needed to have downloaded for installing PEAR. The Git repository is something else. There such file is not included and needs to be downloaded at the installation time. The Git repo is not a PHP release file. ------------------------------------------------------------------------ [2019-08-28 02:22:36] l dot declercq at nuxwin dot com @petk Don't known how you have have made your test but please, don't forget that most of time, we will build in dedicated directory, inside the top build directory. For instance: configure: $(CONFIGURE_TARGETS) configure-%-stamp: patch-stamp prepared-stamp rm -rf $*-build mkdir $*-build cd $*-build && CFLAGS="$(CFLAGS)" PROG_SENDMAIL="$(PROG_SENDMAIL)" ../configure ${$*_CONFIG} cd $*-build && \ cp ../Zend/zend_ini_scanner.c ../Zend/zend_language_scanner.c \ ../Zend/zend_ini_parser.h ../Zend/zend_language_parser.h \ ../Zend/zend_ini_parser.c ../Zend/zend_language_parser.c \ Zend/ touch configure-$*-stamp build: $(BUILD_TARGETS) build-%-stamp: configure-%-stamp cd $*-build && make $(NUMJOBS) touch build-$*-stamp ------------------------------------------------------------------------ [2019-08-28 02:17:44] l dot declercq at nuxwin dot com @petk You're wrong. The line from the configure.ac is still relevant, at least the one creating the pear directory inside the build directory. If the pear directory is missing in the build directory (not the top build directory) and that a packaged phar file is appended in the php release, the installation will fails. About downloading: It would be really a bad choice to rely on network only. ------------------------------------------------------------------------ [2019-08-28 02:16:33] phpbugreports at gmail dot com solved what? i talk about "the installer is always downloaded" which is simply a no-go given that everything which is needed to build has to be part of the tarball for sane and reproduceable builds https://en.wikipedia.org/wiki/Reproducible_builds ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=78460 -- Edit this bug report at https://bugs.php.net/bug.php?id=78460&edit=1