Bug #78469 [NEW]: FastCGI on_accept hook is not called when using named pipes on Windows

From: turchanov at farpost dot com Operating system: Linux PHP version: 7.3.8 Package: FPM related Bug Type: Bug Bug description:FastCGI on_accept hook is not called when using named pipes on Windows Description: ------------ fcgi_accept_request function is supposed to call a FastCGI implementation's on_accept hook when entering an "accepting" stage (that is right before calling "accept"). This hook implementation (fpm_request_accepting) updates a worker state to an "accepting" state which is effectively an "Idle" state, and updates counters on the scoreboard of the corresponding pool (idle++, active--). But this is not done when listening for client connections on a named pipe on Windows platform. In that case a combination of ConnectNamedPipe/WaitForSingleObject is used (to be able to catch in_shutdown as far as I understand), but it is nonetheless functionally equivalent to "accept" call. Also by not calling on_hook neither a worker's state is updated to "accepting" state nor scoreboard counters are updated. So I suggest calling on_accept hook regardless of "named pipe" vs "tcp/unix socket". -- Edit bug report at https://bugs.php.net/bug.php?id=78469&edit=1 -- Fix committed: https://bugs.php.net/fix.php?id=78469&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=78469&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=78469&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=78469&r=needscript Try newer version: https://bugs.php.net/fix.php?id=78469&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=78469&r=support Expected behavior: https://bugs.php.net/fix.php?id=78469&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=78469&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=78469&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=78469&r=globals PHP version support discontinued: https://bugs.php.net/fix.php?id=78469&r=phptooold Daylight Savings: https://bugs.php.net/fix.php?id=78469&r=dst IIS Stability: https://bugs.php.net/fix.php?id=78469&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=78469&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=78469&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=78469&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=78469&r=mysqlcfg