Req #78504 [Opn]: Add warnings to DateTime object with incompatible timezone info
Edit report at https://bugs.php.net/bug.php?id=78504&edit=1
ID: 78504
Updated by: girgias@php.net
Reported by: slawek1211 at gmail dot com
-Summary: DateTime can quietly produce unexpected results
+Summary: Add warnings to DateTime object with incompatible
timezone info
Status: Open
Type: Feature/Change Request
Package: Date/time related
-Operating System: All OS'es (documented)
+Operating System:
-PHP Version: 7.1.32
+PHP Version: Next major version
-Assigned To:
+Assigned To: derick
Block user comment: N
Private report: N
New Comment:
As this adds warnings this would need to be for PHP 8 as it is a BC break, not sure this needs an
RFC so assign to derick which maintains the datetime extension.
Previous Comments:
------------------------------------------------------------------------
[2019-09-06 08:55:39] slawek1211 at gmail dot com
Description:
------------
Hi Guys, i think there's a small issue with how DateTime object works and it can be made much
better with just a very small change. So now when you're using timestamp in constructor or in
DateTime::CreateFromFormat then php silently ommits specified timezone. Same thing happens when you
include timezone in the time itself, and also specify it - then timezone contained in time string
has preference.
This is documented, but very counter-intuitive. So in case where the object gets created with
different timezone than specified in $timezone parameter it would be great to include a warning.
Test script:
---------------
// Example 1
$tz = new DateTimeZone('America/New_York');
$time_o = new DateTime('@'.time(), $tz);
var_dump($time_o->format("Y-m-d H:i:s"));
echo "<br>";
// Example 2
$time_o = DateTime::CreateFromFormat("U", time(), $tz);
var_dump($time_o->format("Y-m-d H:i:s"));
Expected result:
----------------
Add 2 warnings, depending on case.
1. Warning: DateTime object created from timestamp, timezone forced to UTC (ignoring
America/New_York) in line 2
2. Warning: CreateFromFormat has timezone specified both in $time and in $timezone, ignoring
$timezone in line 1
Actual result:
--------------
PHP is silently ignoring optional function parameter specified by user. Which is counter intuitive,
because if someone specifies time and timezone he's probably counting on that time to be
presented in timezone given, despite the format.
Other action which would make it better is to always honor $timezone first. Because many people find
this confusing that the parameter gets ignored in DateTime documentation. But this could break
existing code and probably is much harder to implement so just a warning would be great...
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=78504&edit=1
Thread (4 messages)