Bug #67727 [Com]: Inconsistent loading and saving of DOMDocument
Edit report at https://bugs.php.net/bug.php?id=67727&edit=1
ID: 67727
Comment by: coleman at civicrm dot org
Reported by: villascape at gmail dot com
Summary: Inconsistent loading and saving of DOMDocument
Status: Open
Type: Bug
Package: DOM XML related
Operating System: Centos 6.5
PHP Version: 5.5.15
Block user comment: N
Private report: N
New Comment:
This is still a problem in PHP 7.2. Non-breaking space characters become garbled by both the
saveHTML and the saveXML functions. Strangely, this depends on how it's represented in the
input string fed into loadHTML. Sending it in as a unicode non-break space character triggers the
bug, but sending it in as works fine. The trouble is that saveHTML spits it out as the
unicode character, so a round-trip through DOMDocument and back again will always result in garbled
output. Here is a PHPUnit test to demonstrate the problem:
----------
class myTest extends \PHPUnit\Framework\TestCase {
public function testNbsp() {
$runThrough = function($html) {
$doc = new DOMDocument();
$doc->loadHTML("<html><body><div
id=\"target\">$html</div></body></html>");
$newHtml = '';
foreach ($doc->getElementById('target')->childNodes as $node) {
$newHtml .= $node->ownerDocument->saveXML($node);
}
return $newHtml;
};
$original = '<p>Hello '."\xc2\xa0".' world</p>';
$pass1 = $runThrough($original);
$pass2 = $runThrough($pass1);
$this->assertEquals($pass1, $pass2);
}
}
----------
Note that if we were to extend the test with more iterations, each runThrough will add another extra
character to the output.
Previous Comments:
------------------------------------------------------------------------
[2014-07-31 14:35:02] villascape at gmail dot com
Description:
------------
DOMDocument::loadHTML() and DOMDocument::saveHTML() is not consistent for some input strings;
specifically '<body> </body>'.
Note that I am using PHP version 5.5.14-1.ius.centos6.x86_64, and not 5.5.15.
Test script:
---------------
<?php
$str1='<body> </body>';
echo('Initial<pre>'.htmlspecialchars($str1).'</pre>');
//<body> </body>
$dom = new DOMDocument(); //Default is UTF-8, but iso-8859-1 is available if required
$dom->loadHTML($str1);
$xpath = new DOMXPath($dom);
$body = $dom->getElementsByTagName('body')->item(0);
$str2=$dom->saveHTML($body);
echo('First Option 1<pre>'.htmlspecialchars($str2).'</pre>');
//<body> </body>
$dom->loadHTML($str2);
$xpath = new DOMXPath($dom);
$body = $dom->getElementsByTagName('body')->item(0);
$str3=$dom->saveHTML($body);
echo('Second Option 1<pre>'.htmlspecialchars($str3).'</pre>');
//<body>Ã </body>
?>
Expected result:
----------------
Initial String
<body> </body>
Returned String Pass 1
<body> </body>
Returned String Pass 2
<body> </body>
Actual result:
--------------
Initial String
<body> </body>
Returned String Pass 1
<body> </body>
Returned String Pass 2
<body>Ã </body>
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=67727&edit=1
Thread (2 messages)