Bug #79056 [Csd]: sqlite does not respect PKG_CONFIG_PATH during compilation

Edit report at https://bugs.php.net/bug.php?id=79056&edit=1 ID: 79056 Updated by: nikic@php.net Reported by: naox at yum dot pl Summary: sqlite does not respect PKG_CONFIG_PATH during compilation Status: Closed Type: Bug Package: Compile Failure PHP Version: 7.4.1 Assigned To: cmb Block user comment: N Private report: N New Comment: I've landed a slightly larger patch that should also properly handle shared sqlite builds. Please tell me if you still see any issues. Previous Comments: ------------------------------------------------------------------------ [2020-01-03 10:09:17] nikic@php.net Automatic comment on behalf of nikita.ppv@gmail.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=1dcdcd79badcd0c685580abb2e4e9064ee8cfa80 Log: Fixed bug #79056 ------------------------------------------------------------------------ [2020-01-03 09:38:56] cmb@php.net Ah, that makes sense! naox@, please try nikic's patch. ------------------------------------------------------------------------ [2020-01-03 09:11:16] nikic@php.net @cmb: I don't think this patch makes sense, as the $SQLITE_ prefix is determined by the PKG_CHECK_MODULES() call, which is just SQLITE also in PDO. I'd suggest something like https://gist.github.com/nikic/75dac4f4bff80945127d1acb84e010a0. The main issue here is that EVAL_LIBLINE should be performed before CHECK_LIBRARY, but in this particular case these CHECK_LIBRARY calls should be omitted entirely, per our policy to trust pkg-config when it comes to package existence. ------------------------------------------------------------------------ [2020-01-03 08:01:10] cmb@php.net Could you please try with the attached patch? ------------------------------------------------------------------------ [2020-01-03 08:00:35] cmb@php.net The following patch has been added/updated: Patch Name: 79056 Revision: 1578038435 URL: https://bugs.php.net/patch-display.php?bug=79056&patch=79056&revision=1578038435 ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=79056 -- Edit this bug report at https://bugs.php.net/bug.php?id=79056&edit=1