Bug #79084 [Csd]: mysqlnd may fetch wrong column indexes with MYSQLI_BOTH

Edit report at https://bugs.php.net/bug.php?id=79084&edit=1 ID: 79084 Updated by: cmb@php.net Reported by: rob-phpbugs at tigertech dot com Summary: mysqlnd may fetch wrong column indexes with MYSQLI_BOTH Status: Closed Type: Bug Package: MySQLi related Operating System: Linux PHP Version: 7.3.13 -Assigned To: +Assigned To: cmb Block user comment: N Private report: N New Comment: The fix for this bug has been committed. If you are still experiencing this bug, try to check out latest source from https://github.com/php/php-src and re-test. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2020-01-13 12:24:48] cmb@php.net Automatic comment on behalf of cmbecker69@gmx.de Revision: http://git.php.net/?p=php-src.git;a=commit;h=1752393bb4013ca94d45da5a4d43997a73ae9750 Log: Fix #79084: mysqlnd may fetch wrong column indexes with MYSQLI_BOTH ------------------------------------------------------------------------ [2020-01-12 18:17:07] cmb@php.net That same issue affects PDO core (i.e. with any driver), so I think it's better to track that as separate ticket, so I have filed bug #79106. ------------------------------------------------------------------------ [2020-01-12 17:29:34] cmb@php.net The following pull request has been associated: Patch Name: Fix #79084: mysqlnd may fetch wrong column indexes with MYSQLI_BOTH On GitHub: https://github.com/php/php-src/pull/5080 Patch: https://github.com/php/php-src/pull/5080.patch ------------------------------------------------------------------------ [2020-01-12 14:14:44] cmb@php.net Ah, indeed, if mysqli uses libmysql-client, the numeric indexes are explicitly specified when inserting to the row, but if mysqlnd is used, the values with numeric indexes are added to the row, and as such may be wrong if column names are numeric strings. This likely affects PDO_MySQL as well. ------------------------------------------------------------------------ [2020-01-09 18:10:45] rob-phpbugs at tigertech dot com Ah -- I believe that is exactly what's happening. My PHP 7.2 has: MysqlI Support => enabled Client API library version => 10.1.41-MariaDB And my PHP 7.3 has: MysqlI Support => enabled Client API library version => mysqlnd 5.0.12-dev - 20150407 - $Id: 7cc7cc96e675f6d72e5cf0f267f48e167c2abb23 $ So that must be the cause of this. The mysqlnd version does not appear to match the documentation for mysqli fetch_array at <https://www.php.net/manual/en/mysqli-result.fetch-array.php>, which says that it defaults to MYSQLI_BOTH. If I'm understanding correctly, that means there should be 6 keys in the output of the previous test script, for [0], [1], [2], [2007], [2008] and [2020]. Here's a different test script that shows a different weird result with mysqlnd, apparently caused by the same underlying issue: $ cat test.php <?php $mysqli = mysqli_connect("localhost", "test", "test", "test"); $sql = "SELECT 0 as test, 1 as test2, 2 as 2007, 2 as 2008, 3 as 2020"; $res = $mysqli->query($sql); $row = $res->fetch_array(); print "mysqli version: " . $mysqli->client_info . "\n"; print_r($row); $ php-7.2 test.php mysqli version: 10.1.41-MariaDB Array ( [0] => 0 [test] => 0 [1] => 1 [test2] => 1 [2] => 2 [2007] => 2 [3] => 2 [2008] => 2 [4] => 3 [2020] => 3 ) $ php-7.3 test.php mysqli version: mysqlnd 5.0.12-dev - 20150407 - $Id: 7cc7cc96e675f6d72e5cf0f267f48e167c2abb23 $ Array ( [0] => 0 [test] => 0 [1] => 1 [test2] => 1 [2] => 2 [2007] => 2 [2008] => 2 [2009] => 3 [2020] => 3 ) The mysqlnd version seems wrong; it isn't filling in the expected [3] and [4] keys, and it's added a [2009] key that should not be there. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=79084 -- Edit this bug report at https://bugs.php.net/bug.php?id=79084&edit=1