Edit report at https://bugs.php.net/bug.php?id=78880&edit=1
ID: 78880
Comment by: kocsismate@php.net
Reported by: admin at fossies dot org
Summary: Spelling error report
Status: Closed
Type: Bug
Package: *General Issues
PHP Version: master
Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
I continued what Christopher started, and fixed a lot of other spelling mistakes for the master
branch. I think we are done for now. :)
Previous Comments:
------------------------------------------------------------------------
[2020-01-16 09:04:07] kocsismate@php.net
Automatic comment on behalf of kocsismate@woohoolabs.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=0b4778c377a5753a0deb9cfc697d4f62acf93a29
Log: Fix #78880: Another bunch of spelling errors
------------------------------------------------------------------------
[2019-12-22 18:36:27] admin at fossies dot org
I agree that fixing code mistakes is more important than fixing spelling mistakes.
The word Produkt is now ignored. The word alloced was already marked by
Fossies as "Sloppy short computer slang" but is now also generally ignored. The word
dereferencable seems to be a real misspelling but is now marked as "Common
misspelling in programmer jargon".
Problematic for me as PHP-layman is the decision which directories are to be ignored. After your
remark I tried firstly to ignore the "ext"-subdirectory completely assuming the name means
"external" but looking deeper in the according files I found mostly a PHP copyright. So it
means probably rather "extension" and I searched til depth 2 for subdirectories without a
PHP copyright ending with
date/lib
fileinfo/libmagic
intl/collator
intl/common
intl/converter
intl/dateformat
intl/formatter
intl/grapheme
intl/locale
intl/msgformat
intl/normalizer
intl/resourcebundle
intl/spoofchecker
intl/transliterator
intl/uchar
pcre/pcre2lib
Since your mentioned bundled libraries seems included in the above list that directories are now
also ignored (excluded).
Here the spelling error results with the old and the new codespell configuration:
spelling error false positives
PHP occurrences types occurrences types
7.4.1 1473 308 1873 104 ("old" config)
1385 271 1771 97 ("new" config)
f8f48ce.191129 1247 313 1914 107 ("old" config)
1157 276 1812 101 ("new" config)
dabc28d.191221 520 296 1914 107 ("old" config)
432 259 1812 101 ("new" config)
Here for completeness the current Fossies codespell report URLs:
https://fossies.org/linux/www/php/codespell.html
(https://fossies.org/linux/www/php-7.4.1.tar.xz/codespell.html)
https://fossies.org/linux/test/php-src-master.tar.gz/codespell.html
(https://fossies.org/linux/test/php-src-master-dabc28d.191221.tar.gz/codespell.html)
(https://fossies.org/linux/test/php-src-master-f8f48ce.191129.tar.gz/codespell_fps.html)
------------------------------------------------------------------------
[2019-12-21 11:10:42] cmb@php.net
Thanks again for having created the codespell report and for
having opened this bug ticket! Overall, I think it is a useful
tool, although fixing every single spelling mistake is a lot of
effort which can be spend more reasonably on other tasks. Still I
fixed a lot of mistakes, and the spelling mistake count may now
roughly be halfed.
I didn't notice any real false positives reported by codespell,
but for instance, Produkt must not be fixed for the reported
cases, because it's used to test a German translation. Also,
words like alloced and dereferencable don't appear to be
outright wrong (at least the former seems not uncommon in
programmer jargon).
Finally, there have been some correctly indentified spelling
mistakes regarding some of our bundled libraries (e.g. libpcre2,
libgd, timelib). Fixing these in the bundled libraries doesn't
make sense, since the mistakes would be reintroduced which every
update. Instead it might be sensible to report these spelling
mistakes upstream.
------------------------------------------------------------------------
[2019-12-21 11:09:46] cmb@php.net
Automatic comment on behalf of cmbecker69@gmx.de
Revision: http://git.php.net/?p=php-src.git;a=commit;h=dabc28d18245086a68c88d50dfba380ebd60a236
Log: Fix #78880: Spelling error report
------------------------------------------------------------------------
[2019-12-02 16:31:16] cmb@php.net
Thanks for checking master! I think at least some of these typos
should be addressed; I'll do so as soon as possible.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=78880
--
Edit this bug report at https://bugs.php.net/bug.php?id=78880&edit=1