Req #79275 [Opn]: Support auth_plugin_caching_sha2_password on Windows

From: Date: Tue, 18 Feb 2020 15:20:57 +0000
Subject: Req #79275 [Opn]: Support auth_plugin_caching_sha2_password on Windows
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-225613@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=79275&edit=1

 ID:                 79275
 Updated by:         nikic@php.net
 Reported by:        cmanplus at gmail dot com
 Summary:            Support auth_plugin_caching_sha2_password on Windows
 Status:             Open
 Type:               Feature/Change Request
 Package:            MySQL related
 Operating System:   Windows 10 ver 1903
 PHP Version:        7.4.2
 Block user comment: N
 Private report:     N

 New Comment:

I've removed the VLA uses now, so it should be possible to do a custom build now.


Previous Comments:
------------------------------------------------------------------------
[2020-02-14 15:25:33] nikic@php.net

@cmb: You may want to land the VLA part of that PR independently, so at least custom compiles
(linked against openssl) work.

------------------------------------------------------------------------
[2020-02-14 15:23:04] cmb@php.net

> Official PHP 7.4.2 Windows binaries do not support
> auth_plugin_caching_sha2_password, […]

Indeed; see PR 5129[1] for an inapplicable attempt to support it.
Support might be added in PHP 7.4.4 or later.  We're currently
investigating.

> […] tried to compile locally and failed because of this:

That code is not supposed to be compiled, because MYSQLND_HAVE_SSL
is not supposed to be defined.

[1] <https://github.com/php/php-src/pull/5129>

------------------------------------------------------------------------
[2020-02-14 11:55:45] cmanplus at gmail dot com

Description:
------------
Official PHP 7.4.2 Windows binaries do not support auth_plugin_caching_sha2_password, tried to
compile locally and failed because of this: 

"The compiler must know the size of a type at compile time in order to allocate space for an
instance of that type."

IDE: Visual Studio Community 2017 version 15.9.7
Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27027.1 for x86


> configure "--enable-snapshot-build" "--enable-com-dotnet=shared"
> "--without-analyzer" "--with-pgo"

> nmake

Actual result:
--------------
ext\mysqlnd\mysqlnd_auth.c(809): error C2057: expected constant expression
ext\mysqlnd\mysqlnd_auth.c(809): error C2466: cannot allocate an array of constant size 0
ext\mysqlnd\mysqlnd_auth.c(809): error C2133: 'xor_str': unknown size
ext\mysqlnd\mysqlnd_auth.c(1022): error C2057: expected constant expression
ext\mysqlnd\mysqlnd_auth.c(1022): error C2466: cannot allocate an array of constant size 0
ext\mysqlnd\mysqlnd_auth.c(1022): error C2133: 'xor_str': unknown size



------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=79275&edit=1


Thread (6 messages)

« previous php.bugs (#225613) next »