Edit report at https://bugs.php.net/bug.php?id=79382&edit=1
ID: 79382
Updated by: nikic@php.net
Reported by: admin at franceserv dot fr
Summary: Fatal error: Cannot redeclare getallheaders() in ...
Status: Open
Type: Bug
Package: *General Issues
Operating System: Linux
PHP Version: 7.3.15 and 7.4
Block user comment: N
Private report: N
New Comment:
This is a pretty interesting case. I'm not sure what the correct behavior for this is.
Should we be allowing redefinition of disabled functions? Might be rather problematic technically.
Things would be a lot clearer here if disabled functions were simply completely removed, rather than
replaced with a dummy implementation.
Previous Comments:
------------------------------------------------------------------------
[2020-03-14 14:27:14] bugreports at gmail dot com
that would also work better if you don't want a seperated include file which could be thrown
away all togehter after deciding no longer support anything below PHP 7.3
on newer php versions this would also optimized out completly and avoid the issue of that bugreport
as well as the terrible runtime overhead of function_exists()
if(PHP_VERSION_ID < 70300))
{
function getallheaders()
{
}
}
------------------------------------------------------------------------
[2020-03-14 14:22:39] bugreports at gmail dot com
"disable_functions" should throw an exception when a disabled function is called so one
can handle it proper without spread *slow and expensive* function exists into the codebase -
try/catch is much faster in cases where it don't throw
such compat layers defining a function which is part of a newer php release should go into a include
file because code like below would be completly optimized out by opcache given the constant nature
known at "compile time"
if(PHP_VERSION_ID < 70300)
{
require 'php73.inc.php';
}
------------------------------------------------------------------------
[2020-03-14 14:14:34] admin at franceserv dot fr
This strange behavior seem to exist since 13 years at least :
https://www.php.net/manual/fr/function.function-exists.php#67947
When a function is disabled, if we check this function with function_exists() it's reply
"don't exist", but if we are trying to declare the function it's reply
"exist already". Funny :)
------------------------------------------------------------------------
[2020-03-14 13:20:45] admin at franceserv dot fr
My friend and me found the BUG :)
When the function "getallheaders" is disabled with disable_functions in php.ini, the
function isn't visible by function_exists() but if we redeclare it, it's raise an error
(instead a disabled function warning).
We are thinking it's really a bug because before 7.3 the behavior isn't same.
Could you check on your side please with PHP 7.3.x or 7.4.x ?
------------------------------------------------------------------------
[2020-03-14 12:36:43] admin at franceserv dot fr
Yes exactly, the file is this one :
https://github.com/ralouphie/getallheaders/blob/develop/src/getallheaders.php
The condition "if (!function_exists('getallheaders'))" isn't checked and I
need (same for few people over Internet too) rename the function "function
getallheaders()" to "function _something_different_here_getallheaders()" to avoid the
problem ...
A friend is using PHP 7.4 and he don't have this problem, but I don't know where to look
because a configuration which change behavior of the function "function_exists()" is very
strange.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=79382
--
Edit this bug report at https://bugs.php.net/bug.php?id=79382&edit=1