Bug #79413 [Com]: session_create_id() fails for active sessions
Edit report at https://bugs.php.net/bug.php?id=79413&edit=1
ID: 79413
Comment by: hakhak57 at hotmail dot com
Reported by: hakhak57 at hotmail dot com
Summary: session_create_id() fails for active sessions
Status: Verified
Type: Bug
Package: Session related
Operating System: Macos / linux
PHP Version: Irrelevant
Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
Thx for your quick support
Take care
Previous Comments:
------------------------------------------------------------------------
[2020-03-27 12:48:48] cmb@php.net
Related To: Bug #77178
------------------------------------------------------------------------
[2020-03-26 18:20:59] cmb@php.net
> I think the same problem appears in
> PHP_FUNCTION(session_regenerate_id)
Indeed. I've amended the PR.
> Is it going to be rolled out for 7.2 too ?
We *might* make an exception in this case. That decision would
finally be up to the release managers.
------------------------------------------------------------------------
[2020-03-26 17:55:08] hakhak57 at hotmail dot com
I saw the quick patch you implemented (https://github.com/php/php-src/pull/5305.patch), I think the
same problem appears in PHP_FUNCTION(session_regenerate_id) (line 2226).
I think it should be test against SUCCESS too to realase the id if collision is detected and create
a new one.
It has also been pointed in Bug #77178 (this patch should fix this bug too)
Don't know if i should send a pull request or just tell you.
------------------------------------------------------------------------
[2020-03-26 17:29:20] hakhak57 at hotmail dot com
Thx for your quick answer.
Well it's too bad for the backport but you can't maintain every version i guess. :)
Is it going to be rolled out for 7.2 too ? Saw that you support only security fixes.
------------------------------------------------------------------------
[2020-03-26 14:51:29] cmb@php.net
The following pull request has been associated:
Patch Name: Fix #79413: session_create_id() fails for active sessions
On GitHub: https://github.com/php/php-src/pull/5305
Patch: https://github.com/php/php-src/pull/5305.patch
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=79413
--
Edit this bug report at https://bugs.php.net/bug.php?id=79413&edit=1
Thread (8 messages)