Bug #47983 [PATCH]: mixed LF and CRLF line endings in mail()

Edit report at https://bugs.php.net/bug.php?id=47983&edit=1 ID: 47983 Patch added by: cmb@php.net Reported by: hannibal at astral dot lodz dot pl Summary: mixed LF and CRLF line endings in mail() Status: Verified Type: Bug Package: Mail related Operating System: Linux PHP Version: 5.2.9 Assigned To: cmb Block user comment: N Private report: N New Comment: The following pull request has been associated: Patch Name: Fix #47983: mixed LF and CRLF line endings in mail() On GitHub: https://github.com/php/php-src/pull/5338 Patch: https://github.com/php/php-src/pull/5338.patch Previous Comments: ------------------------------------------------------------------------ [2016-08-02 19:08:03] anrdaemon at freemail dot ru Using a wrapper along the lines of /usr/bin/tee -a "/tmp/sendmail.log" | /usr/sbin/sendmail "$@" it is easy to prove that PHP, indeed, inconsistent in its documentation and internal use of mail handling. In other words, contrary to the http://php.net/manual/en/function.mail.php additional headers must be provided with LF separation. Even on Windows. ------------------------------------------------------------------------ [2009-04-16 09:05:08] hannibal at astral dot lodz dot pl Description: ------------ Diffrent parts of mail function use LF some CRLF. This cause headers to have mixed LF & CRLF endings. This can casue in some situation broken mail delivery. PLEASE do not tell this is MTA problem. This is also your concer to PROVIDE MTA standard compilant headers or at least do this in consistent way. Details: ext/standard/mail.c (PHP 5.2.9) line 147 SKIP_LONG_HEADER_SEP(to_r, i); This code assume that user provide CRLF line ending. If user provide LF only, it is replace by spaces - so it cannot be used. ext/standard/mail.c (PHP 5.2.9) line 273-278 fprintf(sendmail, "To: %s\n", to); fprintf(sendmail, "Subject: %s\n", subject); if (headers != NULL) { fprintf(sendmail, "%s\n", headers); } fprintf(sendmail, "\n%s\n", message); This cleanly show that headers added automatially by PHP are always ended by LF only. In case, where subject is multline, headers always have mixed CRLF and LF. This cause Postfix to left CR in header lines that have it. It can cause probles where buggy Qmail is recipent, it replaces alone CR to empty line, which causes premature end of headers in recipent mail program. Again this is also YOUR PROBLEM, MTA must only properly handling RFC compilant data - when other is sended, behaviour can be undefined. There is a couple methods to fix it, more or less properly. 1. Add "\r" to fprintf - RFC compilant but probably broke many apps which use LF only header endings. 2. Add support to LF ending to SKIP_LONG_HEADER_SEP - also quite easy, but not necessery best. 3. Add prameter to mail function in which user provide desired EOL - best some enum (LEGACY - current buggy, CRLF - RFC compilant, LF - unix compilant) 4. Configuration parameter whith same values as above. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=47983&edit=1