Edit report at https://bugs.php.net/bug.php?id=79519&edit=1
ID: 79519
Comment by: kieran at supportpal dot com
Reported by: kieran at miami-nice dot co dot uk
Summary: Memory leak in PHP 7.4
Status: Open
Type: Bug
Package: Performance problem
Operating System: Linux
PHP Version: 7.4.5
Block user comment: N
Private report: N
New Comment:
Can ignore the master branch. That was an issue in Laravel that I pushed a fix for. I've just
not updated that repository yet.
Previous Comments:
------------------------------------------------------------------------
[2020-05-15 10:45:39] nikic@php.net
It looks like the cause for the "routes" case is the same. However, the "master"
branch is a different issue. Here are the massif outputs for 7.3 and 7.4: https://gist.github.com/nikic/2a5d1a6eb4a4bb82be5e18225ae16d87
------------------------------------------------------------------------
[2020-05-15 09:22:42] nikic@php.net
@kieran: PHP 7.4 fixed some issues related to anonymous functions "overwriting" previous
anonymous functions in the same file under some circumstances. Unfortunately this also means that
this leak is now more pronounced, because this accidental destruction vector no longer exists.
------------------------------------------------------------------------
[2020-05-15 09:16:40] kieran at supportpal dot com
I thought it might be that too, but it seems odd that 7.4 is so much higher when that bug report
suggests the issue exists in most of 7.x
Nothing in the ms_print in my previous message?
I'll check if includes can be memorised.
------------------------------------------------------------------------
[2020-05-15 08:54:12] nikic@php.net
@kieran: The "factories" case looks like https://bugs.php.net/bug.php?id=76982, where a
file declaring an anonymous function is included many times. The anonymous function declaration will
leak in that case. This is a bug in PHP, but not one that will be fixed in 7.4. I'm not
familiar with Laravel's factory system, but it can probably be addressed there by making that
the includes are memoized.
------------------------------------------------------------------------
[2020-05-08 18:23:16] kieran at supportpal dot com
Here's the result from valgrind on the CI server (nothing to do with my reproducers). Anything
jump out Nikita? Not sure why it's blanked a lot of the lines - it's running with
--enable-debug
$ USE_ZEND_ALLOC=0 valgrind --tool=massif php vendor/phpunit/phpunit/phpunit
==25== Massif, a heap profiler
==25== Copyright (C) 2003-2017, and GNU GPL'd, by Nicholas Nethercote
==25== Using Valgrind-3.14.0 and LibVEX; rerun with -h for copyright info
==25== Command: php vendor/phpunit/phpunit/phpunit
==25==
PHPUnit 8.5.4 by Sebastian Bergmann and contributors.
https://gist.githubusercontent.com/bytestream/ad3270993599c720eb7db8ada597eb24/raw/fe94995d1aee1eb64a9e61da07810717fb32e0da/massif.out.25
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=79519
--
Edit this bug report at https://bugs.php.net/bug.php?id=79519&edit=1