Bug #79678 [Ver->Csd]: Build fails due to undeclared ZIP_RDONLY

Edit report at https://bugs.php.net/bug.php?id=79678&edit=1 ID: 79678 Updated by: remi@php.net Reported by: rk at srsbiz dot pl Summary: Build fails due to undeclared ZIP_RDONLY -Status: Verified +Status: Closed Type: Bug Package: Zip Related Operating System: linux PHP Version: master-Git-2020-06-06 (Git) Assigned To: remi Block user comment: N Private report: N New Comment: Automatic comment on behalf of remi Revision: http://git.php.net/?p=php-src.git;a=commit;h=a3bfd4a1082f00eecde9c1feddbdb8adf4a928da Log: Fixed bug #79678 Build fails due to undeclared ZIP_RDONLY Previous Comments: ------------------------------------------------------------------------ [2020-06-07 05:34:28] remi@php.net We have to re-add a guard, but only for ZIP_RDONLY as we want the deprecation message with all libzip version ------------------------------------------------------------------------ [2020-06-06 10:42:29] cmb@php.net We should likely either reinstate that guard, or lift the requirements for master. [1] <https://github.com/php/php-src/blob/php-7.4.6/ext/zip/php_zip.c#L1476-L1489> ------------------------------------------------------------------------ [2020-06-06 10:37:30] requinix@php.net The relevant code was originally wrapped in an #if to check for libzip 1.6, but it was removed... https://github.com/php/php-src/commit/8aab43c85d67fc1c1935f91bc64db800c4ef4754 https://github.com/php/php-src/commit/a4d12f46d1233da4f3518d918c925362b1d9465a Looks like ZIP_RDONLY requires libzip 1.0+ https://github.com/nih-at/libzip/commit/ea8ba499615b7e8911fb6eb57894467723e6723e#diff-de4dcec0a5ec279220ffda60f39f86ff ------------------------------------------------------------------------ [2020-06-06 10:07:25] rk at srsbiz dot pl Description: ------------ Trying to compile from source (revision aa9b0cc) with libzip 0.11.2 (minimal required) /usr/src/php-master/ext/zip/php_zip.c: In function ‘zim_ZipArchive_open’: /usr/src/php-master/ext/zip/php_zip.c:1459:31: error: ‘ZIP_RDONLY’ undeclared (first use in this function) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=79678&edit=1