Bug #55857 [PATCH]: ftp_size on large files
Edit report at https://bugs.php.net/bug.php?id=55857&edit=1
ID: 55857
Patch added by: cmb@php.net
Reported by: websupport at osite dot de
Summary: ftp_size on large files
Status: Analyzed
Type: Bug
Package: FTP related
Operating System: Windows 64bit
PHP Version: 7.3.0alpha4
Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
The following pull request has been associated:
Patch Name: Fix #55857: ftp_size on large files
On GitHub: https://github.com/php/php-src/pull/5757
Patch: https://github.com/php/php-src/pull/5757.patch
Previous Comments:
------------------------------------------------------------------------
[2018-07-23 15:41:30] cmb@php.net
This is fixed for 64bit POSIX systems as of PHP 5.4.20[1], and is
unlikely to get fixed for 32bit systems. However, it won't work
for 64bit Windows, since the function uses atol()[2] which returns
a long.
[1] <http://git.php.net/?p=php-src.git;a=commit;h=a93a462>
[2] <https://github.com/php/php-src/blob/php-7.2.8/ext/ftp/ftp.c#L1144>
------------------------------------------------------------------------
[2013-07-23 17:36:32] lang at b1-systems dot de
The suggested patch uses long instead.
Double is not a good value for file sizes as discussed here: https://bugs.php.net/bug.php?id=44522 https://github.com/php/php-src/pull/372
------------------------------------------------------------------------
[2013-07-23 16:48:58] daltoncaughell at gmail dot com
Stumbled across this issue just thought I would toss in my solution. Just queries
the ftp server for the size and converts the resulting string to a double rather
than an int.
$size = 0;
$result = ftp_raw($conn_id, "SIZE " . <file path>);
$parts = explode(" ", $result[0]);
if($parts[0] === "213") {
$size = doubleval($parts[1]);
}
------------------------------------------------------------------------
[2011-10-06 08:58:23] pajoye@php.net
It depends on the underlying API used for the network operations, the php's stream
implementation.
PHP's stream does not support yet LFS and cannot support it easily by only using
long instead of int (while this breaks the api signature too).
Suspended until we have lfs support.
------------------------------------------------------------------------
[2011-10-06 07:54:34] websupport at osite dot de
Description:
------------
ftp_size does not work on large files > 2gb event not on 64bit systems
can be fixed with the following patch
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=55857&edit=1
Thread (7 messages)