Bug #68948 [Opn->Nab]: feof() on temporary streams broken
Edit report at https://bugs.php.net/bug.php?id=68948&edit=1
ID: 68948
Updated by: cmb@php.net
Reported by: yunosh@php.net
Summary: feof() on temporary streams broken
-Status: Open
+Status: Not a bug
Type: Bug
Package: Streams related
Operating System: Linux
PHP Version: 5.6.5
-Assigned To:
+Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
I think we can close this ticket as not-a-bug *now*, since it was
mostly about the BC break, and this is moot now. Other than that,
php://temp behaves like php://memory now[1].
[1] <https://3v4l.org/E2JL2>
Previous Comments:
------------------------------------------------------------------------
[2015-03-09 03:32:38] slusarz at horde dot org
Realize that my previous comment re: documentation was not very clear at all (in fact, it reads both
ways).
So to clarify, this is what I meant:
In other words, this can be stated as: "When reading from something NOT a regular local file,
it cannot be guaranteed that at the end of any fread() operation that EOF has been reached.
However, when reading from a regular local file, EOF will be returned once the end of the data is
reached."
Thus, feof() behaves differently depending on what the underlying stream is; there is no correct
behavior for all streams - it is stream-dependent.
In memory streams are more analogous to a file than a network stream, because at any given point in
time the in-memory stream has a physical length that is determinative. Therefore, feof() should act
on in-memory streams as it acts on files - returning true once all data has been read from the
stream.
------------------------------------------------------------------------
[2015-03-06 03:18:19] slusarz at horde dot org
Proof that this is backward breaking for 5.5 and 5.6 (not to mention, HHVM). See:
http://3v4l.org/YJRWQ
This is a **CRITICAL** regression from a poorly implemented patch. This is preventing PHP upgrades
on enterprise-level clients. As explained in a previous ticket, the old behavior was NOT broken per
the PHP documentation itself, so this behavior simply cannot change in the middle of point releases.
To try to speed up reverting this, I guess I will implement a patch and submit to github.
------------------------------------------------------------------------
[2015-02-11 14:40:40] adorman at ironicdesign dot com
Just to comment on how critical this bug is, it prevents horde/imp webmail from working and our
users can not access their email.
------------------------------------------------------------------------
[2015-02-09 20:35:33] slusarz at horde dot org
The previous way of handling EOFs in memory streams was entirely compatible with the fread()
documentation -- http://php.net/manual/en/function.fread.php
-- which clearly states (emphasis mine):
"When reading from **anything that is not a regular local file** ... reading will stop after a
packet is available. This means that you should collect the data together in chunks.... (Example
loops through fread() to build a string; it doesn't rely on feof() to return true immediately
when the end of string is reached.)"
In other words, this can be stated as: "When reading from a memory stream, which is NOT a
regular local file, it cannot be guaranteed that at the end of any fread() operation that EOF has
been reached."
Any code that requires feof() to return true in a in-memory stream immediately after a non-empty
fread() return is broken, since this is non-guaranteed behavior. Thus, this fix must be reverted as
it is a backward incompatible change. the base64 filter (or filter code in general) is the
problematic code and is what needs to be fixed.
------------------------------------------------------------------------
[2015-02-09 19:53:39] yunosh@php.net
Changing version because this is a major regression in the latest stable 5.5 and 5.6 releases too.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=68948
--
Edit this bug report at https://bugs.php.net/bug.php?id=68948&edit=1
Thread (10 messages)