Req #80120 [Com]: ForEach() backwards support?

Edit report at https://bugs.php.net/bug.php?id=80120&edit=1 ID: 80120 Comment by: divinity76 at gmail dot com Reported by: divinity76 at gmail dot com Summary: ForEach() backwards support? Status: Feedback Type: Feature/Change Request Package: *General Issues PHP Version: Next Minor Version Block user comment: N Private report: N New Comment: @requinix > For one, this isn't going to work with iterators. Those can only run in one direction. huh, that's a good point. probably won't work with generators/yield either (especially infinite generators with a foreach() containing break; or return; ) > Is there a case where it's "too hard" to do it in reverse manually? no, not really, there's just cases where foreach() would be easier, and that's the reason foreach() exist in the first place; there's no place where iterating forward manually is "too hard" either, right? ^^ Previous Comments: ------------------------------------------------------------------------ [2020-09-18 16:20:02] requinix@php.net For one, this isn't going to work with iterators. Those can only run in one direction. But I'm not sure why this needs to be a feature. It's not hard to set up for loops on arrays, and with iterators there's iterator_to_array + array_reverse (if you know it's safe to do so). Is there a case where it's "too hard" to do it in reverse manually? ------------------------------------------------------------------------ [2020-09-18 08:33:26] divinity76 at gmail dot com Description: ------------ There are situations where one want to iterate a list backwards, I was recently in such a situation, writing: <?php $removeWhitespaceTextNodes = function (\DOMNode $node) use (&$removeWhitespaceTextNodes): void { if ($node->hasChildNodes()) { // Warning: it's important to do it backwards; if you do it forwards, the index for DOMNodeList might become invalidated; // that's why i don't use ForEach() - don't change it (unless you know what you're doing, ofc) for ($i = $node->childNodes->length - 1; $i >= 0; --$i) { $removeWhitespaceTextNodes($node->childNodes->item($i)); } } if ($node->nodeType === XML_TEXT_NODE && !$node->hasChildNodes() && !$node->hasAttributes() && (strlen(trim($node->textContent)) === 0)) { $node->parentNode->removeChild($node); } }; ?> I think it could be useful if ForEach() could iterate stuff backwards, maybe something like: <?php ForEach($iterable as $index=>$val, $flags = 0){} ?> (with a new FOREACH_BACKWARDS flag) or maybe just <?php ForEach($iterable as $index=>$val, bool $backwards = false){} ?> or something like that? ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=80120&edit=1