Bug #80171 [Fbk]: reentrancy.c:139:23: error: too few arguments to function call

Edit report at https://bugs.php.net/bug.php?id=80171&edit=1 ID: 80171 Updated by: nikic@php.net Reported by: smillerdev at me dot com Summary: reentrancy.c:139:23: error: too few arguments to function call Status: Feedback Type: Bug Package: Compile Failure Operating System: macOS 10.15 PHP Version: 7.3.23 Assigned To: nikic Block user comment: N Private report: N New Comment: The referenced commit is on PHP-7.3, so it should at least apply cleanly there :) For older versions, we cannot address this from our side, but I expect passing something like CFLAGS="-Wno-error" or maybe CFLAGS="-Wno-error=implicit-function-declarations" to configure should allow working around the issue. Previous Comments: ------------------------------------------------------------------------ [2020-10-05 09:18:33] smillerdev at me dot com This doesn't apply cleanly to the 7.2/7.3 codebase the issue was occurring in, which is to be expected for a commit based on master. I'm trying to make it work, but I don't think I know enough about the changes between 7.2 and 8.0 on this level to make it work. ------------------------------------------------------------------------ [2020-10-05 08:53:55] nikic@php.net I addressed a number of issues in https://github.com/php/php-src/commit/aa405b7da270595d349d0596ad31305a41d4b1c0. Could you please check whether that makes the build succeed? ------------------------------------------------------------------------ [2020-10-02 17:05:59] php-bugs-2020 at ryandesign dot com Hi, sorry for filing the duplicate #80176; I didn't see this one. Apple did not redefine readdir_r; instead, as of Xcode 12, implicit function declarations are an error. They used to be just warnings. php's configure script fails to include various required headers, causing it to misidentify the system's capabilities (such as how many arguments the readdir_r function needs). php needs to fix its configure script to include the right headers for each test. ------------------------------------------------------------------------ [2020-10-02 16:47:58] cmb@php.net Related To: Bug #80176 ------------------------------------------------------------------------ [2020-10-02 10:01:10] smillerdev at me dot com > Where does the -Werror flag come from in your case? Is this a new default flag in macos 10.15? As far as I know it's added by Homebrew. That has been the case for tons of software years though, without any issues. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=80171 -- Edit this bug report at https://bugs.php.net/bug.php?id=80171&edit=1