Bug #80310 [Com]: ext-intl with icu4c 68.1: use of undeclared identifier 'TRUE'

From: Date: Tue, 03 Nov 2020 16:14:55 +0000
Subject: Bug #80310 [Com]: ext-intl with icu4c 68.1: use of undeclared identifier 'TRUE'
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-230086@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=80310&edit=1

 ID:                 80310
 Comment by:         me at derrabus dot de
 Reported by:        me at derrabus dot de
 Summary:            ext-intl with icu4c 68.1: use of undeclared
                     identifier 'TRUE'
 Status:             Open
 Type:               Bug
 Package:            Compile Failure
 Operating System:   macOS 10.15
 PHP Version:        7.4.12
 Block user comment: N
 Private report:     N

 New Comment:

However, it *does* compile if I configure CXXFLAGS the same way.


Previous Comments:
------------------------------------------------------------------------
[2020-11-03 15:34:05] me at derrabus dot de

If I try this, the error is a different one, but it still does not compile.

/path/to/php-7.4.12/ext/intl/timezone/timezone_class.cpp:328:21: error: use of undeclared identifier
'FALSE'
        tz->getOffset(now, FALSE, rawOffset, dstOffset, uec);
                           ^
/path/to/php-7.4.12/ext/intl/timezone/timezone_methods.cpp:98:57: error: use of undeclared
identifier 'FALSE'
        tz = timezone_convert_datetimezone(tzobj->type, tzobj, FALSE, NULL,
                                                               ^

------------------------------------------------------------------------
[2020-11-03 15:09:29] cmb@php.net

Would it work with

    CFLAGS=-DU_DEFINE_FALSE_AND_TRUE=1

------------------------------------------------------------------------
[2020-11-03 14:03:11] me at derrabus dot de

Description:
------------
I tried to build php 7.4.12 with ext-intl against icu4c 68.1 and the compilation fails with the
error output below. Downgrading to icu4c 67.1 fixes the problem.

This might be related to this change: https://unicode-org.atlassian.net/browse/ICU-21267

Actual result:
--------------
/path/to/php-7.4.12/ext/intl/collator/collator_sort.c:349:26: error: use of undeclared identifier
'TRUE'
        collator_sort_internal( TRUE, INTERNAL_FUNCTION_PARAM_PASSTHRU );
                                ^
/path/to/php-7.4.12/ext/intl/collator/collator_sort.c:543:26: error: use of undeclared identifier
'FALSE'
        collator_sort_internal( FALSE, INTERNAL_FUNCTION_PARAM_PASSTHRU );
                                ^
2 errors generated.
make: *** [ext/intl/collator/collator_sort.lo] Error 1
make: *** Waiting for unfinished jobs....


------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=80310&edit=1


Thread (7 messages)

« previous php.bugs (#230086) next »