Bug #80345 [PATCH]: PHPIZE configuration has outdated PHP_RELEASE_VERSION

From: Date: Tue, 10 Nov 2020 12:54:02 +0000
Subject: Bug #80345 [PATCH]: PHPIZE configuration has outdated PHP_RELEASE_VERSION
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-230250@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=80345&edit=1

 ID:                 80345
 Patch added by:     cmb@php.net
 Reported by:        cmb@php.net
 Summary:            PHPIZE configuration has outdated
                     PHP_RELEASE_VERSION
 Status:             Assigned
 Type:               Bug
 Package:            *Compile Issues
 Operating System:   Windows
 PHP Version:        7.3Git-2020-11-09 (Git)
 Assigned To:        cmb
 Block user comment: N
 Private report:     N

 New Comment:

The following pull request has been associated:

Patch Name: Fix #80345: PHPIZE configuration has outdated PHP_RELEASE_VERSION
On GitHub:  https://github.com/php/php-src/pull/6419
Patch:      https://github.com/php/php-src/pull/6419.patch


Previous Comments:
------------------------------------------------------------------------
[2020-11-09 21:58:10] cmb@php.net

Description:
------------
The configuration on Windows gets the correct version info from
configure.ac[1], what works fine for in-tree builds of extensions,
but not for phpize builds, because get_version_numbers() is not
called for such builds[2].  That means that extensions cannot rely
on PHP_RELEASE_VERSION and PHP_EXTRA_VERSION to have the correct
values in all cases.

[1] <https://github.com/php/php-src/blob/php-7.3.24/win32/build/confutils.js#L121-L151>
[2] <https://github.com/php/php-src/blob/php-7.3.24/win32/build/confutils.js#L162-L164>



------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=80345&edit=1

Thread (3 messages)

« previous php.bugs (#230250) next »