Bug #80402 [Opn->Csd]: configure filtering out -lpthread
Edit report at https://bugs.php.net/bug.php?id=80402&edit=1
ID: 80402
Updated by: nikic@php.net
Reported by: bjornar dot ness at gmail dot com
Summary: configure filtering out -lpthread
-Status: Open
+Status: Closed
Type: Bug
Package: *Configuration Issues
Operating System: linux
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of nikita.ppv@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=ea372e74634f14bdb534f4921e1e325e3f589c8f
Log: Fix bug #80402: Don't strip -lpthread
Previous Comments:
------------------------------------------------------------------------
[2020-11-24 11:27:48] nikic@php.net
The following pull request has been associated:
Patch Name: Don't strip -lpthread
On GitHub: https://github.com/php/php-src/pull/6450
Patch: https://github.com/php/php-src/pull/6450.patch
------------------------------------------------------------------------
[2020-11-24 11:12:03] nikic@php.net
Ah no, that one was about -pthread, not -lpthread. I presume lpthread is getting stripped out by
_PHP_ADD_LIBRARY_SKELETON. That logic was originally added 20 years ago with: https://github.com/php/php-src/commit/f9e375f493a1aeacbbcc8f2f00880d05b4ba7aaf
I have no idea why it is there.
------------------------------------------------------------------------
[2020-11-24 11:06:02] nikic@php.net
Which PHP version are you using? (In particular wondering if you have https://github.com/php/php-src/commit/c518932c0326a938f0fd0254f2adb03b1cddfbca,
which is in 7.4.)
------------------------------------------------------------------------
[2020-11-23 01:19:52] bjornar dot ness at gmail dot com
The only, but ugly, way I have managed to find around this atm is:
LIBS="-lpthread" LDFLAGS="-Wl,--start-group" /path/to/configure
------------------------------------------------------------------------
[2020-11-23 00:20:51] bjornar dot ness at gmail dot com
Description:
------------
php's configure script has multiple places where it filters out -lpthread from $LIBS
before ac_fn_c_try_link
This is likely ok for shared, but causes problems with static libs.
One example of this is when building openssl static.
# pkg-config openssl --libs
-L/usr/src/php-build/install/OpenSSL_1_1_1h/lib -lssl -lz -lcrypto -lpthread -ldl
Problem is, when configure tries to check this rule, it filters out some libs from
what it was told by pkg-config:
(looping through $XXXX_LIBS)
case $ac_ii in
c|c_r|pthread*) ;;
*)
LIBS="$LIBS -l$ac_ii"
;;
esac
(end loop)
ac_fn_c_try_link
ac_fn_c_try_link basically does:
$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&5
and in my case then, results in the following libs:
-lssl -lz -lcrypto -ldl
note -lpthread missing, and the test failing.
I have not managed to find a way around this without modifying the configure file, adding -lpthread
where it needs to be.
The rest of the actual build is just fine after manually adding -lpthread to just the relevant
tests.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=80402&edit=1
Thread (7 messages)