Req #80093 [Opn->Sus]: Please add dynamic defining for class constants
Edit report at https://bugs.php.net/bug.php?id=80093&edit=1
ID: 80093
Updated by: cmb@php.net
Reported by: flexjoly at vfweb dot nl
Summary: Please add dynamic defining for class constants
-Status: Open
+Status: Suspended
Type: Feature/Change Request
Package: Class/Object related
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
A constant which is not constant, is not a constant. IMHO.
Anyhow, consider to pursue the RFC process[1]. For the time
being, I'm suspending this ticket.
[1] <https://wiki.php.net/rfc/howto>
Previous Comments:
------------------------------------------------------------------------
[2020-09-25 13:02:36] flexjoly at vfweb dot nl
Ah, sorry I misunderstood.
We are using define() so far. I do not like that, because:
- the list of constants has grown to big
- there is no grouping possible
- it is not easy to find the constant (with documentation) you need
- a constant can be defined anywhere
Class constants solve those all:
- constants are grouped inside a class
- the list of constants can be managed much better and easier
- a constant can easily be found inside its class with the documentation
- the constant is bound by its class and defining can be controlled by a magic function of that
class
"Most of those don't sound like they need dynamic values."
Some settings in our framework are based on multiple conditions.
Like 'ALLOW_DEBUG' is based on ip-address or "IN_TESTMODE" is based on
ip-address AND permissions of the user.
------------------------------------------------------------------------
[2020-09-22 17:08:34] requinix@php.net
Most of those don't sound like they need dynamic values. For the rest, I was asking more about
why you can't use regular non-class constants created by define().
------------------------------------------------------------------------
[2020-09-22 13:25:05] flexjoly at vfweb dot nl
Hi @requinix,
Thanks for asking.
We have several things for this actually.
We have an in-house vanilla framework, that is running centralized on our vps. All
applications/websites use this framework.
Due to legacy code we have over 100 constantes, which are initialized at start.
These contains things like:
- the used framework version, which can differ per sub-domain
- paths to scripts, includes, ini files etc for the current sub-domain
- current modes/permissions, for debugging, extra logging etc
- current ip's
- etc.
Most of these can be refactored to normal classes with protected properties and public (magic)
functions to get there values.
But for modes, permissions I would like to use class constantes
For that is the 'most secure' since the value cannot be changed after being defined.
And I think functions are taking more performance then a defined constant in a class.
One other reason is like: "why not?" having a define-function for class-constantes. For
then they would function the same as other constantes.... ;-)
Greetz, flexjoly
------------------------------------------------------------------------
[2020-09-20 04:22:05] php-bugs at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
------------------------------------------------------------------------
[2020-09-11 17:07:48] requinix@php.net
What's your use case for needing to define() a constant that has to live on a class?
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=80093
--
Edit this bug report at https://bugs.php.net/bug.php?id=80093&edit=1
Thread (7 messages)