Edit report at https://bugs.php.net/bug.php?id=39992&edit=1
ID: 39992
Comment by: machitgarha at outlook dot com
Reported by: nlopess@php.net
Summary: proc_terminate() leaves children of child running
Status: No Feedback
Type: Bug
Package: Program Execution
Operating System: linux
PHP Version: 6CVS-2006-12-30 (CVS)
Block user comment: N
Private report: N
New Comment:
The bug is reproducible on 7.4.15, Fedora Workstation 33. Any fixes?
Previous Comments:
------------------------------------------------------------------------
[2020-03-15 04:22:04] php-bugs at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
------------------------------------------------------------------------
[2020-03-06 10:38:38] nikic@php.net
I believe this should be addressed in PHP 7.4 by writing:
$proc = proc_open(
['php', '-r', 'while(1){}'],
[2 => ['redirect', 1]],
$pipes);
var_dump(proc_terminate($proc));
This will not go through a shell, and as such the created process will be terminated directly.
Please let me know if there are still issues when going through the shell-free interface.
------------------------------------------------------------------------
[2016-03-06 02:29:59] php at mattwhitlock dot name
An easy workaround...
Instead of:
$proc = proc_open('cat', ...);
Use this:
$proc = proc_open('exec cat', ...);
It tells the shell to replace its own process with the command being executed rather than forking a
child process. This way you can properly kill the command using proc_terminate($proc).
------------------------------------------------------------------------
[2014-10-17 12:12:52] alanevans+phpnet at gmail dot com
I've happened on this same issue also, though I also find that proc_get_status returns only the
pid of some /bin/sh wrapper.
I've tried on PHP 5.5 and 5.6,
Interesting to note is that the behaviour on OSX is quite easy to handle: there is no /bin/sh
wrapper process at all in that case, but on Ubuntu (currently tested on lucid), you only ever have
access to the /bin/sh proc: the process you actually started and the one that you care about is left
running.
I'm going to work around this by having child processes write their own pids to a file and use
those for signalling.
------------------------------------------------------------------------
[2010-03-13 20:19:57] mast at imast dot ru
Well I've also just found this problem.
I run sh script via proc_open and if this script runs child processes that could
hang, they will not be killed if you run proc_terminate().
To fix it I use:
// As soon proc is started
$status = proc_get_status($proc);
posix_setpgid($status['pid'], $status['pid']);
// When I need to kill it
posix_kill(-$status['pid'], 9); // sends SIGKILL to all processes inside group
proc_close($proc);
Why not to add this into proc_terminate() implementation?
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=39992
--
Edit this bug report at https://bugs.php.net/bug.php?id=39992&edit=1