Bug #80024 [PATCH]: Duplication of info about inherited socket after pool removing
Edit report at https://bugs.php.net/bug.php?id=80024&edit=1
ID: 80024
Patch added by: bukka@php.net
Reported by: syazov at plesk dot com
Summary: Duplication of info about inherited socket after
pool removing
Status: Assigned
Type: Bug
Package: FPM related
Operating System: All Unix
PHP Version: 7.4.9
Assigned To: bukka
Block user comment: N
Private report: N
New Comment:
The following pull request has been associated:
Patch Name: FPM: Fix duplication of inherited sockets on reload
On GitHub: https://github.com/php/php-src/pull/6740
Patch: https://github.com/php/php-src/pull/6740.patch
Previous Comments:
------------------------------------------------------------------------
[2021-02-28 21:16:49] bukka@php.net
Thanks I managed to recreate it and also put together a test that was failing before the change and
after applying it, it's passing.
------------------------------------------------------------------------
[2021-02-18 11:23:14] syazov at plesk dot com
Sorry for long silence.
I rechecked the script and found out that it could fail sometimes so I added some delay after
reloads and the error became visible stably.
```
+ rm -f /etc/php/7.4/fpm/pool.d/www_1001.conf
+ date
Thu Feb 18 18:18:52 +07 2021
+ systemctl reload php7.4-fpm
+ systemctl reload php7.4-fpm
+ date
Thu Feb 18 18:18:52 +07 2021
+ sleep 5
+ grep ERROR /var/log/php7.4-fpm.log
[18-Feb-2021 18:18:56] ERROR: epoll: unable to add fd 135
```
------------------------------------------------------------------------
[2021-01-30 20:55:28] bukka@php.net
Hmm so I managed to put together a test for this in fpmi but was not able to make it fail for this
case. So I also tried your script (I'm on Ubuntu 20.04 as well) and it also doesn't fail.
Is that test script actually working for you?
I noticed that you use ondemand so how can this actually fail when no children are running. I guess
I might need to ping the pools at least to create children. Will take a look into this more later
but if you can provide something more re-creatable in the meantime, that would be appreciated.
------------------------------------------------------------------------
[2020-12-29 03:10:37] syazov at plesk dot com
Done, PR#6550 was created and linked.
------------------------------------------------------------------------
[2020-12-29 03:08:12] syazov at plesk dot com
The following pull request has been associated:
Patch Name: Fix bug #80024: prevent duplication of inherited sockets on reload
On GitHub: https://github.com/php/php-src/pull/6550
Patch: https://github.com/php/php-src/pull/6550.patch
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=80024
--
Edit this bug report at https://bugs.php.net/bug.php?id=80024&edit=1
Thread (10 messages)