Bug #80816 [Com]: Missing symbol spl_ce_Countable

From: Date: Wed, 03 Mar 2021 08:55:19 +0000
Subject: Bug #80816 [Com]: Missing symbol spl_ce_Countable
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-232496@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=80816&edit=1 ID: 80816 Comment by: kocsismate@php.net Reported by: jeviwi3279 at timothyjsilverman dot com Summary: Missing symbol spl_ce_Countable Status: Closed Type: Bug Package: Compile Failure Operating System: macOS PHP Version: master-Git-2021-03-01 (snap) Assigned To: kocsismate Block user comment: N Private report: N New Comment: I added commit https://github.com/php/php-src/commit/91739b8c8988013b6416d91e7d9489e91f0c9fa5 to document the change. zend_ce_countable et al. are available from PHP 7.2, so that spl_ce_Countable et al. can be directly replaced with them. I think If it's not possible by any reason, extensions can conditionally declare these aliases themselves. An example for such an alias: https://github.com/xdebug/xdebug/blob/64682a6e035725b9eaca5598bc0f98d6324caa8e/src/lib/compat.h#L89 Previous Comments: ------------------------------------------------------------------------ [2021-03-03 08:44:41] kocsismate@php.net Automatic comment on behalf of kocsismate@woohoolabs.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=91739b8c8988013b6416d91e7d9489e91f0c9fa5 Log: Fix bug #80816 Document the removal of alias class entries from ext/spl ------------------------------------------------------------------------ [2021-03-01 18:57:07] jeviwi3279 at timothyjsilverman dot com It affects the latest releases of the following PECL extensions. 21 in total. I did not check how many of these support PHP 8+ though. AOP, cassandra, ds, hidef, ice, imagick, Judy, mongodb, pecl_http, phalcon, phar, pq, protobuf, pthreads, rdkafka, riak, Weakref, WinBinder, xrange, yaf, zip ------------------------------------------------------------------------ [2021-03-01 17:48:55] kocsismate@php.net To be honest, I'd prefer simply adding the related changelog entry, and not to restore this alias (and the few other ones). These aliases were only needed due to technical reasons, since SPL did some macro magic, like this: https://github.com/php/php-src/pull/6709/files#diff-f86ee648d398a68130b2bff8808bcdb6382278eb198f98c5f6e12cb1f051a23eL1878 Such breaking changes (which affect extension internals) can happen in minor releases. Of course, we don't want to cause very large BC breaks, but this one seems like a very small one for me. Are you sure that a lot of extensions are affected? ------------------------------------------------------------------------ [2021-03-01 13:34:33] jeviwi3279 at timothyjsilverman dot com Yes, it will be a breaking change for many extensions when they are compiled for PHP 8.1. If it is not much effort, it should be restored now and removed later in a major release. Otherwise please add it to the changelog. ------------------------------------------------------------------------ [2021-03-01 13:21:57] nikic@php.net It did get dropped, but it might make sense to restore it? ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=80816 -- Edit this bug report at https://bugs.php.net/bug.php?id=80816&edit=1

« previous php.bugs (#232496) next »