Bug #81088 [NEW]: error in regression test for oci_fetch_object() and oci_fetch_array()

From: mjetzer dot cdc at gmail dot com Operating system: Linux RHEL-8 PHP version: 8.0.6 Package: OCI8 related Bug Type: Bug Bug description:error in regression test for oci_fetch_object() and oci_fetch_array() Description: ------------ ext/reflection/tests/internal_parameter_default_value/check_all.phpt fails with the following: oci_fetch_object: Undefined constant "PHP_OCI_ASSOC" oci_fetch_array: Undefined constant "PHP_OCI_BOTH" I see that most of the oci_* functions in ext/oci8/oci8_arginfo.h with similar default arguments use the OCI_* version of the constant, rather than the PHP_OCI_* versions, but oci_fetch_object() and oci_fetch_array() use the PHP_OCI_* version of the constants. Changing the oci8_arginfo.h declarations to use only the OCI_* version of the constants allows the regression test to run successfully. We do not use any of the oci_* functions directly, only via ADOdb, which provides all necessary arguments and does not default any arguments, so we have no ready means of testing these functions (other than by running the regression tests). These constants are declared using PHP_OCI_* in the current versions of the files in git. Test script: --------------- Run regression test as TEST_PHP_EXECUTABLE=/PATH/TO/sapi/cli/php sapi/cli/php -n -c tmp-php.ini run-tests.php --no-clean ext/reflection/tests/internal_parameter_default_value/check_all.phpt Expected result: ---------------- Regression test runs successfully. Actual result: -------------- Regression test fails with errors described in the Description. -- Edit bug report at https://bugs.php.net/bug.php?id=81088&edit=1 -- Fix committed: https://bugs.php.net/fix.php?id=81088&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=81088&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=81088&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=81088&r=needscript Try newer version: https://bugs.php.net/fix.php?id=81088&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=81088&r=support Expected behavior: https://bugs.php.net/fix.php?id=81088&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=81088&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=81088&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=81088&r=globals PHP version support discontinued: https://bugs.php.net/fix.php?id=81088&r=phptooold Daylight Savings: https://bugs.php.net/fix.php?id=81088&r=dst IIS Stability: https://bugs.php.net/fix.php?id=81088&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=81088&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=81088&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=81088&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=81088&r=mysqlcfg