Bug #81120 [Asn->Csd]: PGO data for main PHP DLL are not used
| From: | git@php.net | Date: | Thu, 10 Jun 2021 21:00:17 +0000 |
| Subject: | Bug #81120 [Asn->Csd]: PGO data for main PHP DLL are not used | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-234363@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=81120&edit=1
ID: 81120
Updated by: git@php.net
Reported by: cmb@php.net
Summary: PGO data for main PHP DLL are not used
-Status: Assigned
+Status: Closed
Type: Bug
Package: *Compile Issues
Operating System: Windows
PHP Version: 8.0.7
Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of cmb69
Revision: https://github.com/php/php-src/commit/21f2ff79de674744e12f713eb59f2e6bf8a7b769
Log: Fix #81120: PGO data for main PHP DLL are not used
Previous Comments:
------------------------------------------------------------------------
[2021-06-09 23:03:43] cmb@php.net
Actually, the PGO trainig already merges the .pgc files into the
.pgd files, so these warnings are expected and harmless.
------------------------------------------------------------------------
[2021-06-09 17:31:40] cmb@php.net
Description:
------------
The main PHP DLL is named php8.dll (or php8ts.dll etc.) as of PHP
8.0.0, but the PGP compile step is still looking for php7!*.pgc
and php7.pgd, what effectively disables the most relevant
profile-guided optimizations.
Test script:
---------------
configure --with-pgo && nmake
Expected result:
----------------
No warnings; profile-guided optimizations should be enabled.
Actual result:
--------------
PGOMGR : warning PG0188: No .PGC files matching
'D:\a\php-ftw\php-ftw\php\vs16\x64\obj\Release\php7!*.pgc' were found.
Reading PGD file 1: D:\a\php-ftw\php-ftw\php\vs16\x64\obj\Release\php7.pgd
D:\a\php-ftw\php-ftw\php\vs16\x64\obj\Release\php7.pgd(0) : warning C4961: No profile data was
merged into 'D:\a\php-ftw\php-ftw\php\vs16\x64\obj\Release\php7.pgd', profile-guided
optimizations disabled
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=81120&edit=1