Bug #60762 [Csd]: IteratorIterator doesn't iterate over DomNodeList
Edit report at https://bugs.php.net/bug.php?id=60762&edit=1
ID: 60762
Updated by: cmb@php.net
Reported by: jthijssen at noxlogic dot nl
Summary: IteratorIterator doesn't iterate over DomNodeList
Status: Closed
Type: Bug
Package: SPL related
PHP Version: 5.4.0RC5
Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
This issue is fixed as of PHP 8.0.0[1]; I suggest to leave it at
this.
[1] <https://3v4l.org/IGWHd>
Previous Comments:
------------------------------------------------------------------------
[2021-07-06 13:53:03] cmb@php.net
This issue is fixed as of PHP 8.0.0[1]; I suggest to leave it at
this.
[1] <https://3v4l.org/IGWHd>
------------------------------------------------------------------------
[2018-08-19 15:27:35] cmb@php.net
Confirmed: <https://3v4l.org/IGWHd>. It get's worse
without the
first iteration, since we'd run into an infinite loop then. The
problem is that moving forward relies on the index member of
zend_object_iterator[1], which is documented to be private, and is
not set from outer iterators. If we're willing to disregard this
privacy further, the attached set-index patch is supposed to solve
the issue.
[1] <https://github.com/php/php-src/blob/php-7.3.0beta1/Zend/zend_iterators.h#L59>
------------------------------------------------------------------------
[2018-08-19 15:27:07] cmb@php.net
The following patch has been added/updated:
Patch Name: set-index
Revision: 1534692427
URL: https://bugs.php.net/patch-display.php?bug=60762&patch=set-index&revision=1534692427
------------------------------------------------------------------------
[2012-01-15 14:59:23] jthijssen at noxlogic dot nl
Description:
------------
When creating an IteratorIterator from a DomNodeList, it doesn't behave correctly. The current
example behaves like the iterator-key is not reset properly when iterating although the value
returned is indeed the first entry of the iterator.
Test script:
---------------
$XML = <<< XML
<root>
<item>1</item>
<item>2</item>
<item>3</item>
</root>
XML;
$dom = new DomDocument();
$dom->loadXml($XML);
$items = $dom->getElementsByTagName('item');
foreach ($items as $k => $item) {
print "K: ".$k." Item: ".$item->nodeName. " Value:
".$item->nodeValue. PHP_EOL;
}
print "----" . PHP_EOL;
$it = new IteratorIterator($items);
foreach ($it as $k => $item) {
print "K: ".$k." Item: ".$item->nodeName. " Value:
".$item->nodeValue. PHP_EOL;
}
Expected result:
----------------
K: 0 Item: item Value: 1
K: 1 Item: item Value: 2
K: 2 Item: item Value: 3
----
K: 0 Item: item Value: 1
K: 1 Item: item Value: 2
K: 2 Item: item Value: 3
Actual result:
--------------
K: 0 Item: item Value: 1
K: 1 Item: item Value: 2
K: 2 Item: item Value: 3
----
K: 3 Item: item Value: 1
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=60762&edit=1
Thread (4 messages)