Req #33147 [Opn->Csd]: proc_open(): "pty pseudo terminal not supported on this system"

From: Date: Fri, 23 Jul 2021 10:30:08 +0000
Subject: Req #33147 [Opn->Csd]: proc_open(): "pty pseudo terminal not supported on this system"
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-235298@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=33147&edit=1

 ID:                 33147
 Updated by:         nikic@php.net
 Reported by:        skissane at iips dot mq dot edu dot au
 Summary:            proc_open(): "pty pseudo terminal not supported on
                     this system"
-Status:             Open
+Status:             Closed
 Type:               Feature/Change Request
 Package:            Program Execution
 Operating System:   *
 PHP Version:        5CVS-2005-05-27
-Assigned To:        
+Assigned To:        nikic
 Block user comment: N
 Private report:     N

 New Comment:

proc_open() pty support was added back in PHP 8.0: https://github.com/php/php-src/commit/a84cd96e865db795edc72b2799eac5c3c67aadfe


Previous Comments:
------------------------------------------------------------------------
[2020-04-30 08:30:29] nikic@php.net

Related To: Bug #64150

------------------------------------------------------------------------
[2020-04-30 08:30:18] nikic@php.net

Related To: Bug #65537

------------------------------------------------------------------------
[2017-10-08 12:56:20] bwg at briangortney dot com

But aren't those comments irrelevant?  The patch adds the '--enable-pty' option,
which would leave it up to the user and/or distribution to enable pty support.  In cases where the
user or distro package manager knows Unix 98 ptys are supported, they can --enable-pty; otherwise,
nothing changes.  It doesn't seem it needs to be 'smarter' than that, to me.  At the
very least, allowing ptys to be used in this way, rather than just disabling entirely (#if 0), is a
step in the right direction.

I'm going to apply the patch to 7.1.10 (manually, I'm sure) and test this morning; will
post the diff (or a PR on github if that's preferred) if it still works.  Looks like it should?

------------------------------------------------------------------------
[2017-10-08 11:53:49] spam2 at rhsoft dot net

things like "open two terminal sessions and become root in them" in the existing comments
are hardly helpful because nobody ever should run

./configure
make test

as root and so whatever somebody proposes needs to work in a completly restricted environment and
must not fail in headless builds like distributions and everybody building packages for distribution
ones to override are using (sise open buildserver, Fedora koji)

------------------------------------------------------------------------
[2017-10-08 10:44:04] bwg at briangortney dot com

This appears to still be an issue?  There are legitimate uses for this, so not sure why it's
being ignored?  Looks like there's a patch, even.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=33147


--
Edit this bug report at https://bugs.php.net/bug.php?id=33147&edit=1


Thread (22 messages)

« previous php.bugs (#235298) next »